Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed :meth:.ThreeDCamera.remove_fixed_orientation_mobjects #2487

Merged
merged 5 commits into from
Feb 9, 2022
Merged

Fixed :meth:.ThreeDCamera.remove_fixed_orientation_mobjects #2487

merged 5 commits into from
Feb 9, 2022

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Jan 24, 2022

self.fixed_orientation_mobjects is a dictionnary, not a set as it is for self.fixed_in_frame_mobjects.

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Darylgolden
Darylgolden requested changes Jan 28, 2022
View reviewed changes
Copy link
Member

@Darylgolden Darylgolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your PR! Can you add a test for this change? (test that the method removes a fixed orientation mobject)

@behackl behackl added test requested Implementation of tests are requested pr:bugfix Bug fix for use in PRs solving a specific issue:bug labels Jan 30, 2022
@behackl behackl changed the title Fixed :meth:.ThreeDCamera.remove_fixed_orientation_mobjects Fixed :meth:.ThreeDCamera.remove_fixed_orientation_mobjects Jan 30, 2022
@behackl behackl added this to the 0.15.0 milestone Feb 2, 2022
@behackl
Copy link
Member

behackl commented Feb 9, 2022

I have added a test.

@behackl behackl removed the test requested Implementation of tests are requested label Feb 9, 2022
@Viicos
Copy link
Member Author

Viicos commented Feb 9, 2022

Sorry forgot to get back on this issue. Thanks @behackl!

Darylgolden
Darylgolden approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@Darylgolden Darylgolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@behackl behackl enabled auto-merge (squash) February 9, 2022 10:06
@behackl behackl merged commit b605d2e into ManimCommunity:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darylgolden Darylgolden Darylgolden approved these changes

Assignees
No one assigned
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Viicos @behackl @Darylgolden