Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a GitHub Action for automatic validation of citation metadata #2531

Merged
merged 3 commits into from
Feb 12, 2022

Conversation

fdiblen
Copy link
Contributor

@fdiblen fdiblen commented Feb 7, 2022

Overview: What does this pull request change?

  • adds a workflow to validate CITATION.cff file

Motivation and Explanation: Why and how do your changes improve the library?

Hello!

We noticed that your repository is using the Citation File Format to store citation metadata in CITATION.cff. This Pull Request automates validation of that file using the cffconvert GitHub Action. That way, it's a little bit easier to be robust against future changes to the CITATION.cff file.

BTW it's perfectly fine if you don't feel like accepting this Pull Request for whatever reason -- we just thought it might be helpful is all.

We found your repository using a partially automated workflow; if you have any questions about that, feel free to create an issue over at https://github.com/cffbots/filtering/issues/

On behalf of the cffbots team,
@abelsiqueira / @fdiblen / @jspaaks

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@Darylgolden
Copy link
Member

Hi, thanks for your PR!

I'm not sure if I'm missing something, but the action doesn't appear to have been run?

@fdiblen
Copy link
Contributor Author

fdiblen commented Feb 7, 2022

Hi, thanks for your PR!

I'm not sure if I'm missing something, but the action doesn't appear to have been run?

Hi @Darylgolden,
As the Pull Request is coming from the fork of your repository, the action will run when it is merged. The fork of the repository is here: https://github.com/cffbots/manim

@Darylgolden
Copy link
Member

Ah, I see now. Won't it be better if it's set to run upon a pull request too, like our other actions? Also, can you provide more details on what your action does? What exactly does it validate?

@Darylgolden
Copy link
Member

I also don't see the action run on your fork.

@fdiblen
Copy link
Contributor Author

fdiblen commented Feb 7, 2022

Ah, I see now. Won't it be better if it's set to run upon a pull request too, like our other actions? Also, can you provide more details on what your action does? What exactly does it validate?

The action validates CITATION.cff file against CFF schema. When there is a problem in the CITATION.cff it will warn you and give you hints to fix it.

The action will be triggered on every push that includes changes in CITATION.cff file. This covers Pull Requests, too.

@fdiblen
Copy link
Contributor Author

fdiblen commented Feb 7, 2022

I also don't see the action run on your fork.

That is expected as I haven't modified CITATION.cff when creating the Pull Request.
I have just updated the cff-version to 1.2.0 to trigger the action. You can see the running action here: https://github.com/cffbots/manim/runs/5093186774?check_suite_focus=true

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Thank you for PRing this!

@behackl behackl added the infrastructure Anything related to our infrastructure label Feb 12, 2022
@behackl behackl merged commit 6ab068e into ManimCommunity:main Feb 12, 2022
ad-chaos pushed a commit to ad-chaos/manim that referenced this pull request Feb 15, 2022
@behackl behackl changed the title Added a GitHub Action for automatic validation of your citation metadata Added a GitHub Action for automatic validation of citation metadata Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything related to our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants