Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiplatform builds for docker images in pipeline #2753

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

behackl
Copy link
Member

@behackl behackl commented Jun 6, 2022

Overview: What does this pull request change?

Follow-up to #2701, simplifies workflow by building both arm and amd images on one machine. Makes docker-buildx work properly.

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@behackl behackl added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label Jun 6, 2022
Copy link
Member

@naveen521kk naveen521kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I previously thought that we could use the native arm64 runners from Oracle to build the images but seems like it creates issues and using buildx should work I guess.

@naveen521kk naveen521kk merged commit 2c5d6c2 into ManimCommunity:main Jun 7, 2022
@behackl behackl added this to the v0.16.0 milestone Jul 10, 2022
@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants