Skip to content

Commit

Permalink
Rollup merge of rust-lang#34499 - michaelwoerister:lldb-blacklist, r=…
Browse files Browse the repository at this point in the history
…alexcrichton

Disable debuginfo tests for a given blacklist of LLDB versions

Anyone having trouble with most LLDB tests failing on OSX, please report your LLDB version here so I can add it to the blacklist.

Blacklisted versions so far:
* lldb-350.*

cc @rust-lang/tools
cc @tedhorst @indutny @jonathandturner (people from the original bug report)

Fixes rust-lang#32520.
  • Loading branch information
Manishearth committed Jun 29, 2016
2 parents 2e893ea + f41de0f commit 5bd3ef8
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions src/tools/compiletest/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,17 @@ pub fn run_tests(config: &Config) {

match config.mode {
DebugInfoLldb => {
if let Some(lldb_version) = config.lldb_version.as_ref() {
if is_blacklisted_lldb_version(&lldb_version[..]) {
println!("WARNING: The used version of LLDB ({}) has a \
known issue that breaks debuginfo tests. See \
issue #32520 for more information. Skipping all \
LLDB-based tests!",
lldb_version);
return
}
}

// Some older versions of LLDB seem to have problems with multiple
// instances running in parallel, so only run one test thread at a
// time.
Expand Down Expand Up @@ -524,3 +535,7 @@ fn extract_lldb_version(full_version_line: Option<String>) -> Option<String> {
}
None
}

fn is_blacklisted_lldb_version(version: &str) -> bool {
version == "350"
}

0 comments on commit 5bd3ef8

Please sign in to comment.