Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset file system support #18

Merged
merged 11 commits into from Feb 3, 2021
Merged

Preset file system support #18

merged 11 commits into from Feb 3, 2021

Conversation

jalil49
Copy link
Contributor

@jalil49 jalil49 commented Jan 29, 2021

Adds file system to the preset menu in H scenes seems to work fine in both Free and Story modes.
known issue: doesn't support KPlug cosplay feature and only overrides main, when character swaps they will at least return to the previous outfit

jalil29 and others added 3 commits January 29, 2021 04:01
requires testing in KKP proper since I have mine modded by replacing files and I don't want to reinstall the whole game from scratch
Support for File system during H for presets
Apparently my original game while uses KKP so i got to test both then.
known issue: doesn't support HPlug Cosplay feature, only main will get changed and thankfully doesn't crash the game
Copy link
Owner

@ManlyMarco ManlyMarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only real issue is bad performance in OnGUI, try caching the value

src/KK_Hooks_KK/HOutfitFolders.cs Outdated Show resolved Hide resolved
src/KK_Hooks_KK/HOutfitFolders.cs Outdated Show resolved Hide resolved
@jalil49 jalil49 marked this pull request as draft January 30, 2021 10:16
now listens for button and right clicks rather that checking GameObject.Find("Canvas/clothesFileWindow") every frame in some way.
remove unused references
@jalil49 jalil49 marked this pull request as ready for review January 30, 2021 14:53
@ManlyMarco ManlyMarco merged commit 05541f6 into ManlyMarco:master Feb 3, 2021
@ManlyMarco
Copy link
Owner

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants