Aggregate button added #65
Conversation
|
After reviewing it, the key brackets were lame, so I changed them to columns. |
|
How does aggregation affect the order column ? Is the order counted from the 1st instance or is it random? |
|
Kind of random. The first value in the sequence of GroupBy return values is used. (group.First()) The order of Dictionary.Values used in KKS is the order in which they were added. We can still read the rough order, but should we make it so that the smallest value in a group is displayed? This is unrelated, but added re-sorting when changing options. |
|
Fixed a problem that the data is not aggregated when _needResort flag is OFF. |
|
I think the smallest value should be used for the order. |
|
Is it this way?
|
|
I just took a look at the source and the current Max implementation should be fine. I'll test it later and merge if all is good. |
|
Sorry if you have already tested it. |
|
Bug fixed. |
|
Tested the latest commit. There appears to be an issue where the list stops updating after enabling and then disabling Aggregation. It sometimes resumes updating after closing and reopening the profiler window, but then the list appears to be corrupted. Unhooking and then re-hooking fixes the issue. Normal After enabling aggregation After disabling aggregation (list no longer updates) After closing and reopening the profiler window (list should be exactly the same as in step 1 but the order values are different and sometimes it doesn't update) |
| @@ -307,10 +321,25 @@ private IEnumerator FrameEndCo() | |||
| } | |||
| } | |||
|
|
|||
| if (_needResort) | |||
| if (_needResort || _aggregation) | |||
There was a problem hiding this comment.
This appears to be a part of the issue, it shouldn't be resorting on every frame.
There was a problem hiding this comment.
Required to update aggregated values.
Aggregated values are not updated by Postfix.
|
Thanks for the review. |
|
It updates correctly now. The only issue left that I can see is the "Ran" column shows the right toggle as It might be best to remove the right toggle in Aggregate mode since some methods might run and others might not. Maybe replace the column with "any ran". Alternatively 3-state checkboxes could be used I suppose, but I'm not sure if IMGUI supports that. |
|
Sorry, I didn't think that far ahead. Remove right toggle when in aggregate mode. Separate aggregate from executed and non-executed. The toggle on the left should now be accurate. Is the SinceLastRun type of byte an intentional specification? |
|
Thanks too for the review and the useful tool! |
Aggregate button added. It aggregates ticks and gcbytes of the same function.
Please merge if you like.
It was clear that DynamicBone was the slowest, but we wanted to be sure. I also wanted to make sure that there were not a large number of instances at the bottom of the list that would cause slowness.