-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Brazil Flag #67
Conversation
Flags/Brazil.html
Outdated
<head> | ||
<title>Brazil | Flags</title> | ||
<style> #brazil { | ||
width: 320px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move #brazil
to next line.
@esganzerla Thank you for contributing. 😄 I have left few fixes required. Apart from that, please update the README.md as per Contributions guidelines and also add snapshot of the flag. |
@manrajgrover I've fixed those issues. In fact I worked a little more to make to organize better the spacings. Thanks |
@esganzerla This differs a little when compared to original flag. Can you share some sources where one developed by you is official? Brilliant work btw. 😄 |
@manrajgrover You mean like this? |
@esganzerla Yeps |
Hey @manrajgrover, I actually managed to insert the stars to the flag. Should do anything else to close this pull request? |
@esganzerla Brilliant work! 😄 This looks perfect to me. One thing left is to resolve the merge conflicts. |
Seems to me that your are the one who can merge, isn't it? I have experience with pull requests, can you help me if I have to do it myself? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@esganzerla Thank you for fixing the conflicts! 😄 |
No description provided.