Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Brazil Flag #67

Merged
merged 10 commits into from
Jul 9, 2017
Merged

Include Brazil Flag #67

merged 10 commits into from
Jul 9, 2017

Conversation

esganzerla
Copy link
Contributor

No description provided.

<head>
<title>Brazil | Flags</title>
<style> #brazil {
width: 320px;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move #brazil to next line.

@manrajgrover
Copy link
Owner

@esganzerla Thank you for contributing. 😄 I have left few fixes required. Apart from that, please update the README.md as per Contributions guidelines and also add snapshot of the flag.

@esganzerla
Copy link
Contributor Author

esganzerla commented Jun 26, 2016

@manrajgrover I've fixed those issues. In fact I worked a little more to make to organize better the spacings. Thanks
brazil

@manrajgrover
Copy link
Owner

@esganzerla This differs a little when compared to original flag. Can you share some sources where one developed by you is official? Brilliant work btw. 😄

@esganzerla
Copy link
Contributor Author

@manrajgrover You mean like this?

@manrajgrover
Copy link
Owner

@esganzerla Yeps

@esganzerla
Copy link
Contributor Author

Hey @manrajgrover, I actually managed to insert the stars to the flag. Should do anything else to close this pull request?

@manrajgrover
Copy link
Owner

@esganzerla Brilliant work! 😄 This looks perfect to me. One thing left is to resolve the merge conflicts.

@esganzerla
Copy link
Contributor Author

esganzerla commented Sep 7, 2016

Seems to me that your are the one who can merge, isn't it?

I have experience with pull requests, can you help me if I have to do it myself?

Thanks

Copy link
Owner

@manrajgrover manrajgrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manrajgrover
Copy link
Owner

@esganzerla Thank you for fixing the conflicts! 😄

@manrajgrover manrajgrover merged commit c0a7d87 into manrajgrover:master Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants