Run stop jobs only if start job succeded and wasn't skipped

Signed-off-by: Adam Reif <Garandor@manta.network>
Manta-Network · Aug 26, 2022 · 3b5ccf4 · 3b5ccf4
1 parent d104f08
commit 3b5ccf4
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 13 deletions.
diff --git a/.github/workflows/check_tests.yml b/.github/workflows/check_tests.yml
@@ -85,9 +85,9 @@ jobs:
       - name: stop sccache server
         run: sccache --stop-server || true
   stop-unit-test-checks:
+    if: jobs.start-unit-test-checks.outcome == 'success'
     needs: start-unit-test-checks
     runs-on: ubuntu-20.04
-    if: ${{ always() }}
     steps:
       - uses: audacious-network/aws-github-runner@v1.0.33
         with:

diff --git a/.github/workflows/integration_test_calamari.yml b/.github/workflows/integration_test_calamari.yml
@@ -431,7 +431,7 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-node-builder-current:
-    if: ${{ always() }}
+    if: jobs.start-node-builder-current.outcome == 'success'
     needs: [start-node-builder-current, build-node-current]
     runs-on: ubuntu-20.04
     steps:
@@ -468,7 +468,7 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-calamari-integration-tester:
-    if: ${{ always() }}
+    if: jobs.start-calamari-integration-tester.outcome == 'success'
     needs: [start-calamari-integration-tester, calamari-integration-test]
     runs-on: ubuntu-20.04
     steps:
@@ -505,7 +505,7 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-docker-image-tester:
-    if: ${{ always() }}
+    if: jobs.start-docker-image-tester.outcome == 'success'
     needs: [start-docker-image-tester, docker-image-test]
     runs-on: ubuntu-20.04
     steps:

diff --git a/.github/workflows/integration_test_dolphin.yml b/.github/workflows/integration_test_dolphin.yml
@@ -394,7 +394,7 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-node-builder-current:
-    if: ${{ always() }}
+    if: jobs.start-node-builder-current.outcome == 'success'
     needs: [start-node-builder-current, build-node-current]
     runs-on: ubuntu-20.04
     steps:
@@ -431,7 +431,7 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-dolphin-integration-tester:
-    if: ${{ always() }}
+    if: jobs.start-dolphin-integration-tester.outcome == 'success'
     needs: [start-dolphin-integration-tester, dolphin-integration-test]
     runs-on: ubuntu-20.04
     steps:

diff --git a/.github/workflows/metadata_diff.yml b/.github/workflows/metadata_diff.yml
@@ -137,9 +137,9 @@ jobs:
           path: |
             output.txt
   stop-checks:
+    if: jobs.start-checks.outcome == 'success'
     needs: start-checks
     runs-on: ubuntu-20.04
-    if: ${{ always() }}
     steps:
       - uses: audacious-network/aws-github-runner@v1.0.33
         with:

diff --git a/.github/workflows/publish_draft_releases.yml b/.github/workflows/publish_draft_releases.yml
@@ -294,7 +294,7 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-node-builder-current:
-    if: ${{ always() }}
+    if: jobs.start-node-builder-current.outcome == 'success'
     needs: [start-node-builder-current, build-node-current]
     runs-on: ubuntu-20.04
     steps:

diff --git a/.github/workflows/run_all_benchmarks.yml b/.github/workflows/run_all_benchmarks.yml
@@ -138,9 +138,9 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-node-builder-current:
+    if: jobs.start-node-builder-current.outcome == 'success'
     needs: [run-benchmarks, start-node-builder-current]
     runs-on: ubuntu-20.04
-    if: ${{ always() }}
     steps:
       - uses: audacious-network/aws-github-runner@v1.0.33
         with:

diff --git a/.github/workflows/run_linters.yml b/.github/workflows/run_linters.yml
@@ -99,9 +99,9 @@ jobs:
       - name: stop sccache server
         run: sccache --stop-server || true
   stop-checks:
+    if: jobs.start-checks.outcome == 'success'
     needs: start-checks
     runs-on: ubuntu-20.04
-    if: ${{ always() }}
     steps:
       - uses: audacious-network/aws-github-runner@v1.0.33
         with:

diff --git a/.github/workflows/runtime_upgrade_test.yml b/.github/workflows/runtime_upgrade_test.yml
@@ -428,7 +428,7 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-node-builder-current:
-    if: ${{ always() }}
+    if: jobs.start-node-builder-current.outcome == 'success'
     needs: [start-node-builder-current, build-node-current]
     runs-on: ubuntu-20.04
     steps:
@@ -465,7 +465,7 @@ jobs:
           aws-image-search-pattern: ${{ env.AWS_IMAGE_SEARCH_PATTERN }}
           aws-image-search-owners: ${{ env.AWS_IMAGE_SEARCH_OWNERS }}
   stop-runtime-upgrade-tester:
-    if: ${{ always() }}
+    if: jobs.start-runtime-upgrade-tester.outcome == 'success'
     needs: [runtime-upgrade-test, check-for-runtime-upgrade, start-runtime-upgrade-tester]
     runs-on: ubuntu-20.04
     steps:

diff --git a/.github/workflows/try-runtime-calamari-mainnet.yml b/.github/workflows/try-runtime-calamari-mainnet.yml
@@ -108,9 +108,9 @@ jobs:
       - name: stop sccache server
         run: sccache --stop-server || true
   stop-checks:
+    if: jobs.start-checks.outcome == 'success'
     needs: start-checks
     runs-on: ubuntu-20.04
-    if: ${{ always() }}
     steps:
       - uses: audacious-network/aws-github-runner@v1.0.33
         with: