Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Nimbus Slot Skipping #794

Closed
Garandor opened this issue Sep 9, 2022 · 1 comment
Closed

Fix Nimbus Slot Skipping #794

Garandor opened this issue Sep 9, 2022 · 1 comment
Assignees
@ghzlatarev
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-bug Category: Issues documenting a bug E-days up to a few days of effort, medium change P-high Priority: High
Milestone
v3.4.0

Comments

@Garandor
Copy link
Contributor

Garandor commented Sep 9, 2022 •
edited
Loading

Currently RelaychainBlockNumberProvider increments twice between parablocks, leading to aura skipping a slot.

I can see 3 approaches

  1. Create a wrapper for RelaychainBlockNumberProvider that simply returns the the number divided by 2 and rounded down
  2. change pallet_aura_style_filter to use halved and rounded down numbers
  3. Change pallet_parachain_staking to always enforce an odd set of selected collators ( might be the easiest way )
@Garandor Garandor added this to the v3.4.0 milestone Sep 9, 2022
@ghzlatarev ghzlatarev mentioned this issue Sep 12, 2022
Closed
6 tasks
@Garandor
Copy link
Contributor Author

Fixed using method 3 in 5c7de13

@Luca-Poggi Luca-Poggi mentioned this issue Oct 13, 2022
Closed
This was referenced Oct 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghzlatarev ghzlatarev

Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-bug Category: Issues documenting a bug E-days up to a few days of effort, medium change P-high Priority: High
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging a pull request may close this issue.

RelayBlockNumberProvider fix Manta-Network/Manta
2 participants
@Garandor @ghzlatarev