Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aura slot skip fix v2 #865

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Aura slot skip fix v2 #865

merged 5 commits into from
Oct 20, 2022

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Oct 19, 2022

Description

  • Don't ignore odd slots (needlessly wastes slots/slows down the chain), have one author be eligible for two consecutive 6s slots instead giving the normal A-B-C-D sequence
  • No longer enforce odd author set in pallet_parachain_staking as the above fix makes this unnecessary

Nimbus diff since v3402: Manta-Network/nimbus@manta-v3.4.1...Manta-Network:nimbus:v3.4.3

followup to #794


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime A-consensus Area: Issues and PRs related to Consensus L-changed Log: Issues and PRs related to changes labels Oct 19, 2022
@Garandor Garandor added this to the v3.4.3 milestone Oct 19, 2022
@Garandor Garandor self-assigned this Oct 19, 2022
@github-actions

This comment was marked as resolved.

Adam Reif added 2 commits October 19, 2022 14:29
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor marked this pull request as ready for review October 19, 2022 19:33
@Garandor Garandor changed the title Aura slot skip fix followup Aura slot skip fix v2 Oct 19, 2022
ghzlatarev
ghzlatarev previously approved these changes Oct 20, 2022
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

edit: linters :(

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor
Copy link
Contributor Author

edit: linters :(

My bad for not running clippy before push

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor merged commit 79b9036 into manta Oct 20, 2022
@Garandor Garandor deleted the garandor/slot-skip-fix2 branch October 20, 2022 21:41
zqhxuyuan pushed a commit that referenced this pull request Dec 7, 2022
* update nimbus ( two chances to produce per 12s slot )

Signed-off-by: Adam Reif <Garandor@manta.network>

* Don't enforce odd collator set in pallet_staking (not needed)

Signed-off-by: Adam Reif <Garandor@manta.network>

* update nimbus with fixed test

Signed-off-by: Adam Reif <Garandor@manta.network>

* fix clippy

Signed-off-by: Adam Reif <Garandor@manta.network>

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-consensus Area: Issues and PRs related to Consensus C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants