Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Include the sink AccountId in the signed message for ToPublic transactions #1032

Merged
merged 14 commits into from
Mar 7, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Mar 4, 2023

Description

Necessary changes to the TransferPost definition and the TransferLedger trait implementation to be compatible with Manta-Network/manta-rs#324


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@SupremoUGH SupremoUGH added L-security Log: Issues and PRs related to security A-security Area: Issues and PRs related to Security A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime L-fixed Log: Issues and PRs related to bug fixes and removed L-security Log: Issues and PRs related to security labels Mar 4, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review March 4, 2023 15:23
@github-actions
Copy link

github-actions bot commented Mar 4, 2023

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
pallets/manta-pay/src/types.rs Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@Garandor Garandor mentioned this pull request Mar 7, 2023
10 tasks
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Garandor
Garandor previously approved these changes Mar 7, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, looks good

pallets/manta-pay/src/lib.rs Show resolved Hide resolved
@ghzlatarev ghzlatarev merged commit a500a1b into manta Mar 7, 2023
@ghzlatarev ghzlatarev deleted the to_public_signature_fix branch March 7, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-security Area: Issues and PRs related to Security L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants