Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial pull method #1046

Merged
merged 14 commits into from
Apr 4, 2023
Merged

Initial pull method #1046

merged 14 commits into from
Apr 4, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Mar 16, 2023

Description

Adds the initial_pull and dense_initial_pull methods on the pallet.

Goes together with:


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@github-actions
Copy link

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

SupremoUGH and others added 3 commits March 17, 2023 13:25
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
…1043)

Signed-off-by: SupremoUGH <francisco@manta.network>
SupremoUGH and others added 2 commits March 22, 2023 18:10
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
SupremoUGH and others added 2 commits March 22, 2023 18:14
Signed-off-by: SupremoUGH <francisco@manta.network>
@SupremoUGH SupremoUGH added L-added Log: Issues and PRs related to addition A-performance Area: Performance-related Issues and PRs A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime labels Mar 22, 2023
@SupremoUGH SupremoUGH marked this pull request as ready for review March 22, 2023 17:36
@SupremoUGH SupremoUGH changed the title initial read method Initial pull method Mar 22, 2023
@ghzlatarev
Copy link
Contributor

Don't try to restart single jobs, I think there's a bug somewhere and they just hang. Better restart all

Cargo.lock Outdated Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Outdated Show resolved Hide resolved
@zqhxuyuan
Copy link
Contributor

zqhxuyuan commented Mar 31, 2023

@SupremoUGH Using manta-rs latest rev commit: f6606ca, has compile issue:

error: failed to select a version for `signature`.
    ... required by package `ecdsa v0.14.4`
    ... which satisfies dependency `ecdsa-core = "^0.14"` of package `k256 v0.11.0`
    ... which satisfies dependency `k256 = "^0.11"` of package `bip32 v0.4.0`
    ... which satisfies dependency `bip32 = "^0.4.0"` of package `manta-pay v0.5.12 (https://github.com/manta-network/manta-rs.git?rev=f6606cae7d9d316f9c84cab49fd8cece4a5dc02a#f6606cae)`
    ... which satisfies git dependency `manta-pay` of package `pallet-manta-pay v4.0.4 (/Users/zqh/code/substrates/Manta/pallets/manta-pay)`
    ... which satisfies path dependency `pallet-manta-pay` (locked to 4.0.4) of package `calamari-runtime v4.0.4 (/Users/zqh/code/substrates/Manta/runtime/calamari)`
    ... which satisfies path dependency `calamari-runtime` (locked to 4.0.4) of package `manta v4.0.4 (/Users/zqh/code/substrates/Manta/node)`
versions that meet the requirements `>=1.5, <1.7` are: 1.6.4, 1.6.3, 1.6.2, 1.5.0

all possible versions conflict with previously selected packages.

  previously selected package `signature v1.4.0`
    ... which satisfies dependency `signature = ">=1.3.1, <1.5"` (locked to 1.4.0) of package `ecdsa v0.13.4`
    ... which satisfies dependency `ecdsa-core = "^0.13"` (locked to 0.13.4) of package `k256 v0.10.4`
    ... which satisfies dependency `k256 = "^0.10.4"` (locked to 0.10.4) of package `frame-support v4.0.0-dev (https://github.com/paritytech/substrate.git?branch=polkadot-v0.9.28#ce10b9f2)`
    ... which satisfies git dependency `frame-support` (locked to 4.0.0-dev) of package `calamari-runtime v4.0.4 (/Users/zqh/code/substrates/Manta/runtime/calamari)`
    ... which satisfies path dependency `calamari-runtime` (locked to 4.0.4) of package `manta v4.0.4 (/Users/zqh/code/substrates/Manta/node)`

Try to manual set signature version to 1.5.0 on calamari runtime:

error: failed to select a version for `signature`.
    ... required by package `calamari-runtime v4.0.4 (/Users/zqh/code/substrates/Manta/runtime/calamari)`
    ... which satisfies path dependency `calamari-runtime` (locked to 4.0.4) of package `manta v4.0.4 (/Users/zqh/code/substrates/Manta/node)`
versions that meet the requirements `^1.5.0` are: 1.6.4, 1.6.3, 1.6.2, 1.5.0

all possible versions conflict with previously selected packages.

  previously selected package `signature v1.3.1`
    ... which satisfies dependency `signature = ">=1.3.1, <1.5"` of package `ecdsa v0.13.3`
    ... which satisfies dependency `ecdsa-core = "^0.13"` of package `k256 v0.10.4`
    ... which satisfies dependency `k256 = "^0.10.4"` of package `frame-support v4.0.0-dev (https://github.com/paritytech/substrate.git?branch=polkadot-v0.9.28#ce10b9f2)`
    ... which satisfies git dependency `frame-support` (locked to 4.0.0-dev) of package `calamari-runtime v4.0.4 (/Users/zqh/code/substrates/Manta/runtime/calamari)`
    ... which satisfies path dependency `calamari-runtime` (locked to 4.0.4) of package `manta v4.0.4 (/Users/zqh/code/substrates/Manta/node)`

failed to select a version for `signature` which could resolve this conflict

I think in manta-rs, upgrade bip32 = "^0.4.0" only when runtime decide to upgrade to v0.9.37+. current substrate frame-support is using old version of k256.

@Dengjianping
Copy link
Contributor

Dengjianping commented Mar 31, 2023

And maybe this new method should be added to zkSBT as well, but we can do it in a separate PR. @zqhxuyuan @ferrell-code

@zqhxuyuan
Copy link
Contributor

zqhxuyuan commented Mar 31, 2023

And maybe this new method should be added to zkSBT as well, but we can do it in a separate PR. @zqhxuyuan @ferrell-code

As zkSBT is already merge to main branch, so we can add this rpc call into zkSBT pallet together. I already have a seperate branch: sbt_extension, @SupremoUGH maybe just pick that branch's latest three commit into this branch.

Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
Signed-off-by: SupremoUGH <francisco@manta.network>
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

zqhxuyuan
zqhxuyuan previously approved these changes Apr 4, 2023
Dengjianping
Dengjianping previously approved these changes Apr 4, 2023
@SupremoUGH SupremoUGH dismissed stale reviews from Dengjianping and zqhxuyuan via 87a117a April 4, 2023 16:51
Signed-off-by: SupremoUGH <francisco@manta.network>
@ghzlatarev ghzlatarev merged commit c9bf02f into manta Apr 4, 2023
@ghzlatarev ghzlatarev deleted the initial_read_method branch April 4, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-performance Area: Performance-related Issues and PRs L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants