Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.0.6 #1073

Merged
merged 19 commits into from
Apr 14, 2023
Merged

Release v4.0.6 #1073

merged 19 commits into from
Apr 14, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Apr 13, 2023

Description

2023-04-13 18:54:38 Connection established to target: Target { sockaddrs: [], host: "ws.manta.systems", host_header: "ws.manta.systems:443", _mode: Tls, path_and_query: "/" }
2023-04-13 18:54:38 scraping key-pairs from remote @ 0x0283a0867e5bb12585d924c05b2c6edecf776633b51fb1cc1e1cb124bd4e230b    
2023-04-13 18:54:38 downloading data for all pallets.    
2023-04-13 18:55:14 adding data for hashed key: 26aa394eea5630e07c48ae0c9558cef7f9cce9c888469bb1a0dceaa129672ef8    
2023-04-13 18:55:14 extending externalities with 1 manually injected key-values    
2023-04-13 18:55:14 πŸ‘©β€πŸ‘¦ scraping child-tree data from 0 top keys    
2023-04-13 18:55:14 Custom("[backend]: frontend dropped; terminate client")
2023-04-13 18:55:14 injecting a total of 2544 top keys    
2023-04-13 18:55:14 injecting a total of 0 child keys    
2023-04-13 18:55:14 initialized state externalities with storage root 0xb2d22d2b2da7019c47a6ffa0a855342874f04685fd6f1565fcb8726a7dcddb17    
2023-04-13 18:55:16 Connection established to target: Target { sockaddrs: [], host: "ws.manta.systems", host_header: "ws.manta.systems:443", _mode: Tls, path_and_query: "/" }
2023-04-13 18:55:16 found matching spec name: "manta"    
2023-04-13 18:55:16 found matching spec version: 4020    
2023-04-13 18:55:16 Custom("[backend]: frontend dropped; terminate client")
2023-04-13 18:55:16 βœ… no migration for System    
2023-04-13 18:55:16 βœ… no migration for AssetManager    
2023-04-13 18:55:16 βœ… no migration for Assets    
2023-04-13 18:55:16 βœ… no migration for Sudo    
2023-04-13 18:55:16 βœ… no migration for Multisig    
2023-04-13 18:55:16 βœ… no migration for Utility    
2023-04-13 18:55:16 βœ… no migration for XTokens    
2023-04-13 18:55:16 βœ… no migration for DmpQueue    
2023-04-13 18:55:16 βœ… no migration for CumulusXcm    
2023-04-13 18:55:16 ⚠️ PolkadotXcm declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(0)`    
2023-04-13 18:55:16 ⚠️ XcmpQueue declares internal migrations (which *might* execute). On-chain `StorageVersion(0)` vs current storage version `StorageVersion(1)`    
2023-04-13 18:55:16 βœ… no migration for Preimage    
2023-04-13 18:55:16 βœ… no migration for Treasury    
2023-04-13 18:55:16 βœ… no migration for Aura    
2023-04-13 18:55:16 βœ… no migration for Session    
2023-04-13 18:55:16 βœ… no migration for CollatorSelection    
2023-04-13 18:55:16 βœ… no migration for Authorship    
2023-04-13 18:55:16 βœ… no migration for AuraAuthorFilter    
2023-04-13 18:55:16 βœ… no migration for AuthorInherent    
2023-04-13 18:55:16 βœ… no migration for ParachainStaking    
2023-04-13 18:55:16 βœ… no migration for TransactionPayment    
2023-04-13 18:55:16 βœ… no migration for Balances    
2023-04-13 18:55:16 βœ… no migration for ParachainInfo    
2023-04-13 18:55:16 βœ… no migration for Timestamp    
2023-04-13 18:55:16 ⚠️ ParachainSystem declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`    
2023-04-13 18:55:16 proof: 250f6465266a9c8d782b360cd2483326184020db84e7115c326d17954521b4f5de6e344052bc537646db8e0528b52ffd0058ccbe04fec0450d12511050eb281dc4afe01a274976831c1acf18ef2172d09deb14088e6da3c2e67a397df96a447ec3e847d3ec6c484a0b782d68e1d9ba5fd36995bd42631581c57be1abea136bd3b6ad6db90991524a29534a016713de105c11352441451a7434d5f00312458b5dec0b548534fefd8b9fcf567593eb5a4c49dcaa7ff4b92fe7b56aab4bee519eead5e5ce7d7a252f793a6df5e4283fc9d7aaac57f2e4ce2fa9f15fa75651674cc9ced3ad5247b9d4f6a9b6e4fee417f7b2bb91dafea5eda34edab6ca778d549fe7ad4687eefc72cc51db6f00fbd496e0f3765d4d65f8e8abd5e9b07d39ecfbb07539d4b9f455c9cdad365bd5feb4cabf1eb525f7ebac65ad6a67cc6837b8d15eb1efbb1b7a4d4d4d4d4d45ce558bc43d8ae10fce9dd62463afcf495627eca2c7b7eb388dbf4b13dfeef3b42619fbf23f96e1dabeaea52c2764d9bb14d15d8312df357cf1dded178e747809f13059cf7376e7d1a53bcc484ade56c1adbedfb72d6177ce615ccb816c5b358079f8dba2c18adf9c30fcded2559439158e6315b2c55460fd7bdbdc58cc0f90c2014fc27c716e97b574bdb115588fb49b12d3afd776de8caba021cc6f8b86a6aff39f17e0b7c5e5ccbfe843ac6b175388adc0faa7843f...299b2fbcadf815b238bccf806e769c2c0a31ae61439e62342d386ced2e3d2cc6eff0526a1c02bcae64d0570480a58c35efd0298b77c9fb78ed22edee44e5783ade0bbccd5a4974596d874cd4a3810e80104c5d0b9012096b41c4eb3aaf947f6ea429080100485d00959dca9d4616632a822d7523ba6304009e8f185207498abb5c213d0fb059b3d85000806133cd7ea2dd2ebf26cb3976b46a64ecb34aabad0a916d1096242c5e4ec596bf585f0323ae84c43568be0d1394d5d0d522c410020000009f05323df7cc47150b3930e2666b0aa3133d354c5f0a6ccf00f78ac824e72d27429ca3b8b004008027d293b7c1f82de8b4cb28ef8cd8f7e6f666edfa59bc72b5fc10d6bbc8e0c9a24c5f0dca42deb008c6559ee789c9b9f70a2c040080ce26713589dfb681da82046f8bebf1c3ba2f8e08eff1891451b75b7627bac30180b6d4a79cc3f582422719172a6b1f3430249d7ec3bc5d5b3e30c8651952f9501680e68c0d01a58719a5c98b894b55157cc9c2058d29f197596aaf2b9a4ffe217e1a585f02bca190d36bd834cc73a38fc213ecbd107bf8e500805ae5bda76f097712679dd9fef970cd379a571bc7cd3fdf4fa391a4cf028ff7fd805ca0141495d20d9b96963cb634d48f4236aa567c9e907f39a82259482bd13dcac26340000080479663c2e310fcced0af32800410a5c34ecb40429216b46022f1d2b62b629d2b / 11 nodes    
2023-04-13 18:55:16 proof size: 744.54 KB (762411 bytes)    
2023-04-13 18:55:16 compact proof size: 744.26 KB (762121 bytes)    
2023-04-13 18:55:16 zstd-compressed compact proof 744.28 KB (762145 bytes)    
2023-04-13 18:55:16 TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = 225000000, total weight = 500000000000 (0.00045)  

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime L-changed Log: Issues and PRs related to changes L-release Related to a release labels Apr 13, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@github-actions
Copy link

github-actions bot commented Apr 13, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev marked this pull request as ready for review April 13, 2023 15:58
@ghzlatarev ghzlatarev requested review from Garandor, ferrell-code, Dengjianping and zqhxuyuan and removed request for Garandor April 13, 2023 15:58
ferrell-code and others added 3 commits April 13, 2023 17:37
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weights and release look good

we need a followup to etch out the runtime upgrade test process on release as @ghzlatarev was saying as v4.0.5 manta-local is not the version now on manta mainnet.

I'd actually say - even for this release - make the job manually triggered and allow to manually select the client version in addition to manta-local. that way we can run it against the correct runtime version

@Garandor
Copy link
Contributor

rococo alice didn't make it to block 25 in the integration test, last one is
2023-04-13 22:31:54 ✨ Imported #23 (0x9185…954e)

not sure what the docker-image-test promise rejection is about

@Garandor
Copy link
Contributor

P.S. Don't use L-release, a release should be annotated with L-skip ( i'd delete the L-release label but idk if the other repos are using it )

@Garandor Garandor added L-skip Log: Will be skipped on changelog generation and removed L-changed Log: Issues and PRs related to changes L-release Related to a release labels Apr 13, 2023
@ghzlatarev
Copy link
Contributor Author

Details

Yeah ill just reduce it to 15. Looking into the docker stuff...

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Copy link
Contributor Author

weights and release look good

we need a followup to etch out the runtime upgrade test process on release as @ghzlatarev was saying as v4.0.5 manta-local is not the version now on manta mainnet.

I'd actually say - even for this release - make the job manually triggered and allow to manually select the client version in addition to manta-local. that way we can run it against the correct runtime version

Yeah i'll change it now.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev dismissed Garandor’s stale review April 14, 2023 04:28

Should be resolved now.

Dengjianping
Dengjianping previously approved these changes Apr 14, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev self-assigned this Apr 14, 2023
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments but they're unimportant, i'll approve and merge so we can proceed with the release

@Garandor Garandor merged commit ceb9e46 into manta Apr 14, 2023
@Garandor Garandor deleted the release-v4.0.6 branch April 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants