New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tx fees diff support #1083
tx fees diff support #1083
Conversation
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
|
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
One more question, should I add it to manta now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to expand coverage of multiple extrinsic call params
I would cover those extrinsics which are open to users, but like governance extrinsics, I will ignore them, just leave one case there. |
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter is broken, otherwise lgtm
https://github.com/Manta-Network/Manta/actions/runs/5285745613/jobs/9564520599?pr=1083
Also the unit tests are failing after the latest manta-sbt change |
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
|
✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost |
Signed-off-by: Dengjianping <djptux@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we need to bump the timeouts of the integration tests jobs from 180 to 240 or something like that.
Description
Closes #807
With this pr merge, we will no need to look at new weights when they're updated.
Maybe it's not a smart implementation, at least, we can get rid of reviewing weight numbers.
diff_gas_fees.rs
. All computations base on actual fee multiplier.diff_gas_fees.rs
.tx-fees-data
.diff_gas_fees::diff_gas_fees
will fail.Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.