Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex amm #1122

Merged
merged 9 commits into from
Jun 1, 2023
Merged

dex amm #1122

merged 9 commits into from
Jun 1, 2023

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented May 24, 2023

Description

Part1 of standard dex amm.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan zqhxuyuan added A-calamari Area: Issues and PRs related to the Calamari Runtime A-security Area: Issues and PRs related to Security C-experiment Category: Experimental feature or tool L-added Log: Issues and PRs related to addition labels May 24, 2023
@github-actions
Copy link

github-actions bot commented May 24, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

pallets/asset-manager/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset-manager/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset-manager/src/lib.rs Show resolved Hide resolved
pallets/asset-manager/src/lib.rs Show resolved Hide resolved
pallets/asset-manager/src/tests.rs Outdated Show resolved Hide resolved
ferrell-code and others added 2 commits May 27, 2023 12:31
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
node/src/rpc/calamari.rs Outdated Show resolved Hide resolved
pallets/asset-manager/src/lib.rs Show resolved Hide resolved
pallets/asset-manager/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset-manager/src/lib.rs Outdated Show resolved Hide resolved
runtime/calamari/src/zenlink.rs Outdated Show resolved Hide resolved
runtime/calamari/src/zenlink.rs Show resolved Hide resolved
@Dengjianping
Copy link
Contributor

We should forbidden to transfer LP token by xcm.

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@ghzlatarev ghzlatarev merged commit b71ab07 into manta Jun 1, 2023
29 checks passed
@ghzlatarev ghzlatarev deleted the dex_amm branch June 1, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-security Area: Issues and PRs related to Security C-experiment Category: Experimental feature or tool L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants