You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
Added one label out of the L- group to this PR
Added one or more labels from the A- and C- groups to this PR
Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
Re-reviewed Files changed in the Github PR explorer.
Situational Notes:
If adding functionality, write unit tests!
If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
Because rebenchmarking mantapay uses a concrete chain spec, which contains some storage that will affect benchmark code, like there're some asset ids registered already, so we cannot register them in benchmark code.
Because rebenchmarking mantapay uses a concrete chain spec, which contains some storage that will affect benchmark code, like there're some asset id registered already, so we cannot register in benchmark code.
right can we just exclude MantaPay from our benchmark test in check-tests workflow
A-automationArea: Issues and PRs related to AutomationA-calamariArea: Issues and PRs related to the Calamari RuntimeA-ciArea: Continuous IntegrationA-developmentArea: Development Resources and UpgradesA-mantaArea: Issues and PRs related to the Manta RuntimeA-manta-payArea: Issues and PRs related to the MantaPay PalletA-weightsArea: Issues and PRs related to Substrate WeightsL-changedLog: Issues and PRs related to changes
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dengjianping
added
A-weights
Description
Closes #1146
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-group to this PRA-andC-groups to this PRA-calamariand/orA-mantaif your changes are meant for/impact either of these (CI depends on it)Files changedin the Github PR explorer.Situational Notes:
BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.