Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manta v4201 hotfix release #1165

Merged
merged 11 commits into from
Jun 27, 2023
Merged

Manta v4201 hotfix release #1165

merged 11 commits into from
Jun 27, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jun 19, 2023

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes L-skip Log: Will be skipped on changelog generation labels Jun 19, 2023
@ghzlatarev ghzlatarev self-assigned this Jun 19, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev and others added 4 commits June 26, 2023 11:09
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above target_daily_congestion_cost_kma

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above target_daily_congestion_cost_kma

Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to redo manta weights as the force calls were benchmarked locally on my computer

@ghzlatarev
Copy link
Contributor Author

might want to redo manta weights as the force calls were benchmarked locally on my computer

Ran the CI, you can reference it in the description.

ferrell-code
ferrell-code previously approved these changes Jun 26, 2023
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah don't know how I didn't see that

@ghzlatarev
Copy link
Contributor Author

Ah yeah don't know how I didn't see that

Well, actually maybe i can change it in the pallet as well. Will make the changelog have 4.2.0-1 manually.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Copy link
Contributor Author

actually @ferrell-code can you finish this PR off and change the SBT reserve price to something smaller than 100k MANTA

Signed-off-by: Charles Ferrell <charlie@manta.network>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to update changelog-tool to handle this version style.

@ghzlatarev ghzlatarev merged commit 6548518 into manta Jun 27, 2023
44 of 45 checks passed
@ghzlatarev ghzlatarev deleted the release-v4.2.0-1 branch June 27, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-enhancement Category: An issue proposing an enhancement or a PR with one L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants