Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mantapay rpc tests to manta runtime #1207

Merged
merged 8 commits into from Jul 14, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Jul 13, 2023

Description

  • Enable MantaPay rpc tests on manta runtime
  • Removed the old parachain block parsing tests (which were disabled anyway)
  • added average block time check to our stress tests that it should be less than 13 seconds

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs L-added Log: Issues and PRs related to addition A-client Client - i.e. not upgradeable with the runtime - changes C-enhancement Category: An issue proposing an enhancement or a PR with one labels Jul 13, 2023
@ghzlatarev ghzlatarev self-assigned this Jul 13, 2023
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@ghzlatarev ghzlatarev added the A-calamari Area: Issues and PRs related to the Calamari Runtime label Jul 13, 2023
ghzlatarev and others added 5 commits July 13, 2023 12:03
|

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>
@ghzlatarev ghzlatarev marked this pull request as ready for review July 13, 2023 15:00
@ghzlatarev ghzlatarev merged commit f4f3dde into manta Jul 14, 2023
35 checks passed
@ghzlatarev ghzlatarev deleted the ghzlatarev/manta-runtime-rpc-for-manta-pay branch July 14, 2023 10:40
ghzlatarev added a commit that referenced this pull request Jul 14, 2023
* Add mantapay rpc tests to manta runtiem

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add avg block time test to mocha tests

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix avg block test|
|

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add logs

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update average block time test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Don't await in lambda

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update stress_benchmark_test.ts

Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>

---------

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev added a commit that referenced this pull request Jul 15, 2023
…equalize Manta and Calamari randomness - 1 epoch ago) (#1216)

* Bump spec version

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use 1 epoch ago randomness in calamari as well

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* bench only xcm pallets

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* bench only lotter

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* bench only lottery and dex

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Revert

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Bump client

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update changelog

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update xcm weights

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Benc pallet-lottery only

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* recommit

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix wrong reports of congestion test results (#1208)

* print to congestion test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* print to congestion test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update check_tests.yml

Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>

* Update check_tests.yml

Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>

* Revert push branch

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update check_tests.yml

update reported message

Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>

---------

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update changelog

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update lottery weights

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update DCO workflow

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update changelog

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add mantapay rpc tests to manta runtime (#1207)

* Add mantapay rpc tests to manta runtiem

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add avg block time test to mocha tests

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix avg block test|
|

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add logs

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update average block time test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Don't await in lambda

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update stress_benchmark_test.ts

Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>

---------

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update changelog

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Unfilter pallet-xcm send

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update xcmPallet send origin and mocks

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Remove redundant comment

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update xcm execute filter

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

---------

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-client Client - i.e. not upgradeable with the runtime - changes A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes A-testing Area: Testing-related Issues and PRs C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MantaPay RPC tests for Manta runtime Re-enable parachain parse block tests in CI integration tests
3 participants