Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

farming rpc test #1217

Merged
merged 41 commits into from Jul 20, 2023
Merged

farming rpc test #1217

merged 41 commits into from Jul 20, 2023

Conversation

zqhxuyuan
Copy link
Contributor

@zqhxuyuan zqhxuyuan commented Jul 14, 2023

Description

not add to manta CI yet, as run test suites not opened for now:
This rpc testcase only for manta runtime.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan zqhxuyuan added L-added Log: Issues and PRs related to addition C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime labels Jul 14, 2023
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 14, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we make the test run for custom/custom asset pair instead of the native/custom pair.
Then we can have it run for Calamari as well ?

Btw ill open a PR to uncomment the rpc correctness and performance test you mentioned in the description - #1221

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
tests/chain-util.ts Outdated Show resolved Hide resolved
ghzlatarev
ghzlatarev previously approved these changes Jul 17, 2023
@ghzlatarev ghzlatarev self-requested a review July 17, 2023 13:59
tests/manta_pay.ts Outdated Show resolved Hide resolved
@ghzlatarev ghzlatarev self-requested a review July 17, 2023 14:00
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan zqhxuyuan added the A-calamari Area: Issues and PRs related to the Calamari Runtime label Jul 17, 2023
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but seems that ci is failing

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@Dengjianping
Copy link
Contributor

Seems mantapay rpc tests didn't get passed.

@ghzlatarev
Copy link
Contributor

Seems mantapay rpc tests didn't get passed.

They rely on starting from a clean state, that's why they should be first.

@zqhxuyuan
Copy link
Contributor Author

zqhxuyuan commented Jul 19, 2023

Seems mantapay rpc tests didn't get passed.

They rely on starting from a clean state, that's why they should be first.

Ah, But I have this timeout issue when put farming test after manta pay test.

https://github.com/Manta-Network/Manta/actions/runs/5595302834/jobs/10231502632

@ghzlatarev
Copy link
Contributor

Seems mantapay rpc tests didn't get passed.

They rely on starting from a clean state, that's why they should be first.

Ah, But I have this timeout issue when put farming test after manta pay test.

https://github.com/Manta-Network/Manta/actions/runs/5595302834/jobs/10231502632

It seems it hangs up on this loop after the first attempt to execute a runtime upgrade https://github.com/Manta-Network/Manta/blob/farming_rpc_test/tests/test-farming.ts#L136-L139
I suppose the rpc correctness/performance tests could be messing up the state, as they simply call set_storage with junk data.
The easiest fix would be to split them into their own job like the stress test ones, or run them with the stress test. But that has some assets already registered from 8-17

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
ghzlatarev
ghzlatarev previously approved these changes Jul 20, 2023
@ghzlatarev ghzlatarev merged commit b965066 into manta Jul 20, 2023
35 checks passed
@ghzlatarev ghzlatarev deleted the farming_rpc_test branch July 20, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants