Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lottery): TooLowDelegationCountToDelegate fails when funds withdrawing #1219

Merged
merged 18 commits into from Jul 18, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Jul 15, 2023

Signed-off-by: Adam Reif Garandor@manta.network

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Adam Reif and others added 14 commits July 12, 2023 10:31
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
…artial_deposit_works2. Passes

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
…redeposit

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
This reverts commit d4e7c09.

Signed-off-by: Adam Reif <Garandor@manta.network>
…ings when restaking

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
- refactor: disambiguate Deposit failure errors
- tests: adapt to above
- tests: sync lottery timer to staking rounds in mock

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-bug Category: Issues documenting a bug L-fixed Log: Issues and PRs related to bug fixes A-manta Area: Issues and PRs related to the Manta Runtime labels Jul 15, 2023
@github-actions
Copy link

github-actions bot commented Jul 15, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 15, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

Signed-off-by: Adam Reif <Garandor@manta.network>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same changes as #1218 in this pr but lgtm

@Garandor
Copy link
Contributor Author

same changes as #1218 in this pr but lgtm

yeah i built these sequentially, if 1218 is merged first the changeset just rebases

Signed-off-by: Adam Reif <Garandor@manta.network>
Adam Reif added 2 commits July 18, 2023 06:55
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor requested a review from ghzlatarev July 18, 2023 11:58
@ghzlatarev ghzlatarev merged commit 2e30f4f into manta Jul 18, 2023
35 checks passed
@ghzlatarev ghzlatarev deleted the jumboshrimps_fix_3 branch July 18, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta Area: Issues and PRs related to the Manta Runtime C-bug Category: Issues documenting a bug L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants