Roll srtool image back to 1.66.1 #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dengjianping <djptux@gmail.com>
Dengjianping
added
C-bug
ghzlatarev
approved these changes
Jul 19, 2023
|
reopen the issue please |
I just triggered a release build with rust 1.69 + srtool 1.66.1 |
|
✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost |
|
|
Dengjianping
requested review from
zqhxuyuan,
Garandor,
Apokalip,
ghzlatarev and
ferrell-code
|
can produce blocks while start a new network. |
ferrell-code
approved these changes
Jul 19, 2023
ghzlatarev
approved these changes
Jul 19, 2023
Garandor
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1158
See this release build: https://github.com/Manta-Network/Manta/actions/runs/5598593294/jobs/10238435337
We have to stick to srtool image 1.66.1, probably unless we bump deps to latest or recent release.
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-group to this PRA-andC-groups to this PRA-calamariand/orA-mantaif your changes are meant for/impact either of these (CI depends on it)Files changedin the Github PR explorer.Situational Notes:
BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.