Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize/deserialize vfr key #1234

Merged
merged 2 commits into from Jul 25, 2023
Merged

Serialize/deserialize vfr key #1234

merged 2 commits into from Jul 25, 2023

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Jul 22, 2023

Description

Fix parsing vfr key in chain spec while start nodes by zombienet

Error: Service(Other("Error parsing spec file: missing field `vrf` at line 143 column 13"))
2023-07-22 23:26:52 Building chain spec    

Closes #1233


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-serialization Area: Issues and PRs related to Serialization L-fixed Log: Issues and PRs related to bug fixes labels Jul 22, 2023
@Dengjianping Dengjianping self-assigned this Jul 22, 2023
@github-actions
Copy link

github-actions bot commented Jul 22, 2023

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Jul 22, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@Dengjianping Dengjianping marked this pull request as ready for review July 23, 2023 02:59
@Dengjianping Dengjianping merged commit c633150 into manta Jul 25, 2023
18 checks passed
@Dengjianping Dengjianping deleted the serialize-vrf-key branch July 25, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-serialization Area: Issues and PRs related to Serialization C-enhancement Category: An issue proposing an enhancement or a PR with one L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization for vrf key is missing
3 participants