New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zombienet examples #1249
Merged
Merged
Add zombienet examples #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Dengjianping
added
C-enhancement
Category: An issue proposing an enhancement or a PR with one
A-manta
Area: Issues and PRs related to the Manta Runtime
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-automation
Area: Issues and PRs related to Automation
A-testing
Area: Testing-related Issues and PRs
L-added
Log: Issues and PRs related to addition
A-benchmark-checks
A-integration-test-checks
A-congestion-test-checks
A-unit-test-checks
and removed
A-congestion-test-checks
A-manta
Area: Issues and PRs related to the Manta Runtime
A-calamari
Area: Issues and PRs related to the Calamari Runtime
labels
Sep 18, 2023
ferrell-code
previously approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually linters ci is failing
weird, it failed to install taplo-cli. i will take a look at it. |
Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
ghzlatarev
approved these changes
Sep 26, 2023
ferrell-code
approved these changes
Sep 26, 2023
grenade
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-automation
Area: Issues and PRs related to Automation
A-benchmark-checks
A-integration-test-checks
A-testing
Area: Testing-related Issues and PRs
A-unit-test-checks
C-enhancement
Category: An issue proposing an enhancement or a PR with one
L-added
Log: Issues and PRs related to addition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.