Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zombienet examples #1249

Merged
merged 6 commits into from Sep 26, 2023
Merged

Add zombienet examples #1249

merged 6 commits into from Sep 26, 2023

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Aug 22, 2023

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping self-assigned this Aug 22, 2023
@Dengjianping Dengjianping marked this pull request as ready for review September 18, 2023 14:56
@Dengjianping Dengjianping added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-automation Area: Issues and PRs related to Automation A-testing Area: Testing-related Issues and PRs L-added Log: Issues and PRs related to addition A-benchmark-checks A-integration-test-checks A-congestion-test-checks A-unit-test-checks and removed A-congestion-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime labels Sep 18, 2023
ferrell-code
ferrell-code previously approved these changes Sep 22, 2023
zombienet/examples/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually linters ci is failing

@Dengjianping
Copy link
Contributor Author

actually linters ci is failing

weird, it failed to install taplo-cli. i will take a look at it.

Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
@ghzlatarev ghzlatarev merged commit f187435 into manta Sep 26, 2023
19 checks passed
@ghzlatarev ghzlatarev deleted the zombienet-examples branch September 26, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-automation Area: Issues and PRs related to Automation A-benchmark-checks A-integration-test-checks A-testing Area: Testing-related Issues and PRs A-unit-test-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants