New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4.4.0-1 #1256
Release v4.4.0-1 #1256
Conversation
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should bump transaction version due to #1236
good catch, thanks |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how we want to deal with changelog version checker maybe fix the tool itself, lgtm
Don't want to spend time on it. It's because of the |
Description
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.A-integration-test-checks
to run start-integration-test-checks (Required)A-benchmark-checks
to run start-benchmark-check (Required)A-unit-test-checks
to run start-unit-test-checks (Required)A-congestion-test-checks
to run start-integration-test-checks (Optional)Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.