Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.4.0-1 #1256

Merged
merged 3 commits into from Sep 27, 2023
Merged

Release v4.4.0-1 #1256

merged 3 commits into from Sep 27, 2023

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Sep 26, 2023

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added A-runtime Area: Issues and PRs related to Runtimes L-skip Log: Will be skipped on changelog generation labels Sep 26, 2023
@ghzlatarev ghzlatarev self-assigned this Sep 26, 2023
@ghzlatarev ghzlatarev marked this pull request as ready for review September 26, 2023 16:54
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above the target daily congestion cost

Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should bump transaction version due to #1236

@ghzlatarev
Copy link
Contributor Author

should bump transaction version due to #1236

good catch, thanks

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how we want to deal with changelog version checker maybe fix the tool itself, lgtm

@ghzlatarev
Copy link
Contributor Author

not sure how we want to deal with changelog version checker maybe fix the tool itself, lgtm

Don't want to spend time on it. It's because of the -1

@ghzlatarev ghzlatarev merged commit 902e20c into manta Sep 27, 2023
27 of 28 checks passed
@ghzlatarev ghzlatarev deleted the release-v4.4.0-1 branch September 27, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-congestion-test-checks A-integration-test-checks A-runtime Area: Issues and PRs related to Runtimes A-unit-test-checks L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants