Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix CHANGELOG.md #1336

Open
wants to merge 1 commit into
base: manta
Choose a base branch
from
Open

🐛 fix CHANGELOG.md #1336

wants to merge 1 commit into from

Conversation

anaye1997
Copy link
Contributor

Signed-off-by: Anathan (Ana) Ye anaye@duck.com

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
@anaye1997 anaye1997 added A-calamari Area: Issues and PRs related to the Calamari Runtime A-benchmark-checks A-unit-test-checks L-skip Log: Will be skipped on changelog generation A-manta Area: Issues and PRs related to the Manta Runtime A-integration-test-checks labels May 23, 2024
- [\#1303](https://github.com/Manta-Network/Manta/pull/1303) Release 4.6.1-1 [MA]
- [\#1315](https://github.com/Manta-Network/Manta/pull/1315) change p asset check [MA]
- [\#1328](https://github.com/Manta-Network/Manta/pull/1328) fix kick ottery [MA]
- [\#1326](https://github.com/Manta-Network/Manta/pull/1326) Release 4.6.2 [MACA]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be its own release... I think the tool has wrong output

Copy link
Contributor Author

@anaye1997 anaye1997 May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we fix this?

like we generate notes for 4.6.0 first, then update this markdown file and then repeat for 4.6.1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the devtool needs to be fixed that generates the diff https://github.com/Manta-Network/dev-tools/tree/main/changelog-generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-manta Area: Issues and PRs related to the Manta Runtime A-unit-test-checks L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants