Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split KMA and MA currency #225

Merged
merged 4 commits into from
Oct 21, 2021
Merged

Split KMA and MA currency #225

merged 4 commits into from
Oct 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2021

Splits KMA and MA into different currencies, one with 18 decimals and the other with 12.

Moves currency and fee modules out of manta-primitives and into both calamari-pc and manta-pc.

closes: #206


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or manta-pc) with right title (start with [Manta] or [Manta-PC]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics

@ghost ghost requested review from stechu and ghzlatarev October 19, 2021 20:11
Copy link
Collaborator

@stechu stechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stechu
Copy link
Collaborator

stechu commented Oct 20, 2021

@tommyjk21 one small thing before merging. Can you add this to the CHANGELOG.md so that this can be automatically included in the next release note.

@stechu stechu merged commit 13b60c9 into manta-pc Oct 21, 2021
@stechu stechu deleted the feature/split-kma-ma branch October 22, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define KMA like MA in manta runtime
3 participants