Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calamari/Manta]Deposit all fees to block authors #275

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Nov 20, 2021

Description

closes: #274


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or dolphin) with right title (start with [Manta] or [Dolphin]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics

@Dengjianping Dengjianping requested review from stechu, ghzlatarev and a user November 20, 2021 16:03
@Dengjianping Dengjianping changed the title [Calamari]Deposit all fees to block authors [Calamari/Manta]Deposit all fees to block authors Dec 1, 2021
@Dengjianping Dengjianping added this to the v3.1.1 milestone Dec 1, 2021
@Dengjianping Dengjianping marked this pull request as ready for review December 7, 2021 14:11
@Dengjianping Dengjianping merged commit f182e81 into manta Dec 17, 2021
@Dengjianping Dengjianping deleted the jamie/handle-fees branch December 17, 2021 02:47
@ghzlatarev ghzlatarev mentioned this pull request Dec 17, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deposit fees to block authors before we enable treasury
3 participants