New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[All] Split up manta_primitives lib.rs & [Manta&Calamari] Port parity's fast-runtime cargo feature #383
Conversation
Build fast RTs with cargo build --release --features=fast-runtime or customize, to e.g. 1 minute period interval with env variable MANTA_PERIOD=5 cargo build --release --features=fast-runtime Taken from https://github.com/paritytech/polkadot/pull/4332/files?diff=unified&w=1
@ghzlatarev Please have a look whether the Calamari Democracy pallet fast defaults make sense |
Nevermind, CI passed. However i still can't get the parachain to start collating using polkadot-launch. Not sure yet if it's due to my config. |
@Dengjianping check out this revision, it's a larger PR but I think having the types module makes the code cleaner |
Managed to test a fast-runtime locally using All good according to me |
@Garandor merge conflicts after the |
Conflicts resolved, ready to merge |
Thanks for this cleaning up PR. Please merge conflicts. |
The XCM test code needs to adapt to this new change as well. See the failed unit test. |
@stechu the PR finished CI and is ready to merge |
run tests with runtime-benchmarks & try-runtime instead of --all--features
@stechu Ready to merge again |
@Garandor Thanks for the PR! |
Description
Closes #357
Port of paritytech/polkadot#4332
Allows building Manta/Calamari runtimes with session and democracy times set to much shorter 2 or 5 minutes instead of their production values and for customizable timings using environment variables.
Env variables are ignored unless the RT is built with
--features=fast-runtime
in which case they overwrite the (shortened) defaults.Build fast RTs with
cargo build --release --features=fast-runtime
or customize, to e.g. 1 minute period interval with env variable
MANTA_PERIOD=5 cargo build --release --features=fast-runtime
Variables are named as capitalized versions of their name in the parameter_types! macro prefixed with MANTA_ or CALAMARI_ respectively
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
manta
ordolphin
) with right title (start with [Manta] or [Dolphin]),Wrote unit tests.N/A, buildtime changes onlyUpdated relevant documentation in the code.N/A, buildtime changes onlyFiles changed
in the Github PR explorer.If runtime changes, need to update the version numbers properlyN/A, buildtime changes onlyIf needed, notify the committer this is a draft-release and a tag is needed after merging the PR.N/A, is feature PRVerify benchmarks & weights have been updated for any modified runtime logicsN/A, buildtime changes onlyIf needed, bumpN/A, buildtime changes onlyversion
for every crate.If import a new pallet, choose a proper module index for it, and allow it inN/A, buildtime changes onlyBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.N/A, buildtime changes onlyIf we're going to issue a new release, freeze the code one week early(it depends, but usually it's one week), ensure we have enough time for related testing.N/A, Is feature PR