Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dolphin] Dolphin Testnet V2 Runtime #430

Merged
merged 23 commits into from Mar 28, 2022
Merged

[Dolphin] Dolphin Testnet V2 Runtime #430

merged 23 commits into from Mar 28, 2022

Conversation

stechu
Copy link
Contributor

@stechu stechu commented Mar 4, 2022

Description

closes: #XXXX

Dolphin Testnet V2 runtime:

  • Integrate Pallet-Manta-Pay
  • Integrate Asset-Manager and Pallet-Assets
  • Initial Benchmark for new Pallet-Manta-Pay

Update: cannot really do genesis configuration properly until this PR: paritytech/polkadot#4997 is merged.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or dolphin) with right title (start with [Manta] or [Dolphin]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If needed, bump version for every crate.
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If we're going to issue a new release, freeze the code one week early(it depends, but usually it's one week), ensure we have enough time for related testing.
  • Check if inheriting any upstream runtime storage migrations. If any, perform tests with try-runtime.

@stechu stechu force-pushed the manta-pay-integration branch 2 times, most recently from 3a79f3e to 14b923f Compare March 5, 2022 23:31
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
@stechu stechu marked this pull request as ready for review March 14, 2022 22:37
pallets/manta-pay/Cargo.toml Outdated Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Outdated Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Show resolved Hide resolved
pallets/manta-pay/Cargo.toml Outdated Show resolved Hide resolved
pallets/manta-pay/README.md Outdated Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Outdated Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Show resolved Hide resolved
runtime/primitives/src/assets.rs Outdated Show resolved Hide resolved
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
@stechu stechu requested review from bhgomes and removed request for ghzlatarev March 28, 2022 03:36
@stechu
Copy link
Contributor Author

stechu commented Mar 28, 2022

@Dengjianping @bhgomes ready for review.

node/src/command.rs Show resolved Hide resolved
pallets/manta-pay/src/benchmark/mod.rs Outdated Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Outdated Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Outdated Show resolved Hide resolved
pallets/manta-pay/src/bin/precompute_coins.rs Show resolved Hide resolved
pallets/manta-pay/src/lib.rs Outdated Show resolved Hide resolved
pallets/manta-pay/src/test/payment.rs Outdated Show resolved Hide resolved
primitives/src/assets.rs Outdated Show resolved Hide resolved
primitives/src/assets.rs Outdated Show resolved Hide resolved
pallets/asset-manager/src/lib.rs Show resolved Hide resolved
pallets/manta-pay/README.md Show resolved Hide resolved
.editorconfig Show resolved Hide resolved
@Dengjianping
Copy link
Contributor

There're some unwraps in the lib.rs. I suggest we remove them.

Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
@stechu stechu merged commit 8082383 into manta Mar 28, 2022
@stechu stechu deleted the manta-pay-integration branch March 28, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants