-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[manta]Add strip profile to production #449
Conversation
Signed-off-by: Dengjianping <djptux@gmail.com>
Seems like srtool doesn't want the runtime to be built without strip: |
Yeah, srtool is blocking us, I just created an issue in srtool, not sure when it will be fixed. |
one of us might be misinterpreting the error The way I understand it It's not about not being stabilized (the last part of the error message is misleading here), it's about the CI build in your change trying to make a binary without So it'd be about srtool allowing unstripped builds, not about unstableness EDIT: nvm, just saw that |
@Garandor can you give an explicit review of this PR (approve or request change)? |
We have to wait, it seems parity will publish a release(0.9.20) for fixing this problem. |
Signed-off-by: Dengjianping <djptux@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for 3.2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflicts
Signed-off-by: Dengjianping <djptux@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dengjianping djptux@gmail.com
Description
Remove
strip
from CI, and addstrip
profile to production.https://doc.rust-lang.org/stable/cargo/reference/profiles.html#strip
closes: #325
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inhreited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.