New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix potential expect() panic in runtime code, two xcm must-fail tests, and filter out unneeded XTokens extrinsics #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
ghzlatarev
force-pushed
the
ghzlatarev/dophin-xcm-improvments
branch
from
March 22, 2022 14:59
626b795
to
743575e
Compare
ghzlatarev
requested review from
stechu and
Dengjianping
and removed request for
stechu
March 22, 2022 15:00
ghzlatarev
added
the
A-xcm
Area: Issues and PRs related to Cross-Consensus Messaging (XCM)
label
Mar 22, 2022
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Dengjianping
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ghzlatarev
changed the title
Fix potential expect() panic in the runtime and two xcm must-fail tests
Fix potential expect() panic in the runtime, two xcm must-fail tests, and filter out unneeded XToken extrinsics
Mar 26, 2022
ghzlatarev
changed the title
Fix potential expect() panic in the runtime, two xcm must-fail tests, and filter out unneeded XToken extrinsics
Fix potential expect() panic in the runtime, two xcm must-fail tests, and filter out unneeded XTokens extrinsics
Mar 26, 2022
ghzlatarev
changed the title
Fix potential expect() panic in the runtime, two xcm must-fail tests, and filter out unneeded XTokens extrinsics
Fix potential expect() panic runtime code, two xcm must-fail tests, and filter out unneeded XTokens extrinsics
Mar 26, 2022
ghzlatarev
changed the title
Fix potential expect() panic runtime code, two xcm must-fail tests, and filter out unneeded XTokens extrinsics
Fix potential expect() panic in runtime code, two xcm must-fail tests, and filter out unneeded XTokens extrinsics
Mar 26, 2022
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
stechu
approved these changes
Apr 6, 2022
stechu
pushed a commit
that referenced
this pull request
Apr 9, 2022
…, and filter out unneeded XTokens extrinsics (#454) * Get rid of expect() in the runtime Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> * Filter out all XTokens extrinsics until transfer() until they are needed Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> * Add log target Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> * Fix tests Signed-off-by: ghzlatarev <ghzlatarev@gmail.com> Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #442
take_revenue
function of our XCM code had anexpect
call which can potentially panic. Removing the expect and handling the error now.XTokens
extrinsics excepttransfer()
until they are practically needed.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inhreited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.