Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential expect() panic in runtime code, two xcm must-fail tests, and filter out unneeded XTokens extrinsics #454

Merged
merged 6 commits into from Apr 6, 2022

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Mar 22, 2022

Description

closes: #442

  • The take_revenue function of our XCM code had an expect call which can potentially panic. Removing the expect and handling the error now.
  • Added a couple of test scenarios where it that code would previously panic.
  • Filter out all XTokens extrinsics except transfer() until they are practically needed.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inhreited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
@ghzlatarev ghzlatarev force-pushed the ghzlatarev/dophin-xcm-improvments branch from 626b795 to 743575e Compare March 22, 2022 14:59
@ghzlatarev ghzlatarev requested review from stechu and Dengjianping and removed request for stechu March 22, 2022 15:00
@ghzlatarev ghzlatarev marked this pull request as ready for review March 22, 2022 15:01
@ghzlatarev ghzlatarev requested a review from stechu March 22, 2022 15:01
@ghzlatarev ghzlatarev self-assigned this Mar 22, 2022
@ghzlatarev ghzlatarev added the A-xcm Area: Issues and PRs related to Cross-Consensus Messaging (XCM) label Mar 22, 2022
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Copy link
Contributor

@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghzlatarev ghzlatarev changed the title Fix potential expect() panic in the runtime and two xcm must-fail tests Fix potential expect() panic in the runtime, two xcm must-fail tests, and filter out unneeded XToken extrinsics Mar 26, 2022
@ghzlatarev ghzlatarev changed the title Fix potential expect() panic in the runtime, two xcm must-fail tests, and filter out unneeded XToken extrinsics Fix potential expect() panic in the runtime, two xcm must-fail tests, and filter out unneeded XTokens extrinsics Mar 26, 2022
@ghzlatarev ghzlatarev changed the title Fix potential expect() panic in the runtime, two xcm must-fail tests, and filter out unneeded XTokens extrinsics Fix potential expect() panic runtime code, two xcm must-fail tests, and filter out unneeded XTokens extrinsics Mar 26, 2022
@ghzlatarev ghzlatarev changed the title Fix potential expect() panic runtime code, two xcm must-fail tests, and filter out unneeded XTokens extrinsics Fix potential expect() panic in runtime code, two xcm must-fail tests, and filter out unneeded XTokens extrinsics Mar 26, 2022
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
@stechu stechu merged commit 9e5d146 into manta Apr 6, 2022
stechu pushed a commit that referenced this pull request Apr 9, 2022
…, and filter out unneeded XTokens extrinsics (#454)

* Get rid of expect() in the runtime

Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>

* Filter out all XTokens extrinsics until transfer() until they are needed

Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>

* Add log target

Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>

* Fix tests

Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Signed-off-by: Shumo Chu <shumo.chu@protonmail.com>
@stechu stechu deleted the ghzlatarev/dophin-xcm-improvments branch June 23, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-xcm Area: Issues and PRs related to Cross-Consensus Messaging (XCM)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve XCM tests
3 participants