Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the path of repository #474

Merged
merged 4 commits into from Apr 12, 2022
Merged

Conversation

Dengjianping
Copy link
Contributor

Signed-off-by: Dengjianping djptux@gmail.com

Description

Currently, some of dependencies in the section dev-dependencies does or doesn't end with .git. The same to the section in dependencies.
But once we run cargo test, the lock file is always being updated with or without the tag .git in Cargo.lock. We should avoid it.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inhreited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <djptux@gmail.com>
@Dengjianping Dengjianping self-assigned this Apr 7, 2022
@Dengjianping Dengjianping added the C-enhancement Category: An issue proposing an enhancement or a PR with one label Apr 7, 2022
@Dengjianping Dengjianping added this to the v3.1.5 milestone Apr 7, 2022
@Dengjianping
Copy link
Contributor Author

This is a minor change, I won't update the changelog.

@stechu
Copy link
Contributor

stechu commented Apr 9, 2022

@Dengjianping LGTM. please resolve the conflicts.

Signed-off-by: Dengjianping <djptux@gmail.com>
pallets/asset-manager/Cargo.toml Outdated Show resolved Hide resolved
@Garandor
Copy link
Contributor

Garandor commented Apr 10, 2022

Not quite sure why the test is failing, it's succeeding on manta branch
thread 'benchmarking::benchmark_tests::test_benchmarks' panicked at 'assertion failed: !anything_failed', pallets/asset-manager/src/benchmarking.rs:136:1

EDIT: Oh, you're missing the merge of #461 that fixes this - just merge manta again

Signed-off-by: Dengjianping <djptux@gmail.com>
Signed-off-by: Dengjianping <djptux@gmail.com>
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dengjianping Dengjianping merged commit 31c43de into manta Apr 12, 2022
@Dengjianping Dengjianping deleted the jamie/complete-repo-path branch April 12, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants