-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement TransactAsset
with FungibleLedger
and AssetConfig
traits
#563
Conversation
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
AssetTransactor
with FungibleLedger
and AssetConfig
traitsTransactAsset
with FungibleLedger
and AssetConfig
traits
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
merge conflicts to resolve |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as it's an XCM PR I'd like to ask @Dengjianping and @stechu to review for approval here as well
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Please resolve clippy warnings. |
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Great PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot i never sent this review 🥇
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if you fix the changelog in #614 after merging this
…raits (#563) * Inital refactor, does not compile Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Inital refactor, does not compile Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Inital refactor, does not compile Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Compiles Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Should work Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * AssetId and u32 thing Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Works with concrete Balance and AssetId Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Works with concrete Balance and AssetId Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Simplify and error handling Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Names Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Names Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Use new struct for AssetTransactor Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Clean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix runtime/common/Cargo.toml Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix tests Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Clean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Comments Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix integration test Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix manta-pay test, changelog, more clean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Add trace logs in TransactAsset impl Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Equalize Barrier impl between production and xcm-mock Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Rever the Barrier change to not explode the scope of the PR Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Add comments Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Taplo fmt Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix clippy Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * PR comments Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Revert how assets are registered Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix clippy Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * fix changelog Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Cover allow death case Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Cover allow death case Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Shumo Chu <shumo.chu@pm.me>
Description
closes: #534
FungiblesTransactor
andLocalAssetTransactor
tuple with our ownAssetTransactor
implementor calledMultiAssetAdapter
MultiAssetAdapter
uses the unified interface ofFungibleLedger
trait to implement only thewithdraw_asset
anddeposit_asset
functions fromTransactAsset
TransactAsset
interface like can_check_in, teleport, etc are not required. Even though they were implemented in our old configuration they were not used.burn
function and implementation had to be added to ourFungiblesLedger
trait. This implementation allows accounts to go down to 0, as that was the behavior of the old configuration.ReducedToZero
return results incan_withdraw
implementation were considered an error, when in fact they are a success case, so switched that.ReducedToZero
was considered an error, this case was also holding up.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.