-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce CI failure rate by switching AWS CI runners from AMD to Intel #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
added
T-devops
Team: Relevant for the DevOps Team
A-ci
Area: Continuous Integration
labels
Jul 6, 2022
Garandor
changed the title
Switch AWS CI runners to intels from AMD
Switch AWS CI runners from AMD to Intel
Jul 6, 2022
Garandor
changed the title
Switch AWS CI runners from AMD to Intel
Reduce CI failure rate by switching AWS CI runners from AMD to Intel
Jul 6, 2022
ghzlatarev
reviewed
Jul 6, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Adam Reif <Garandor@manta.network>
Garandor
force-pushed
the
garandor/intel-ci
branch
from
July 6, 2022 20:48
1bb10a6
to
9a426fc
Compare
ghzlatarev
previously approved these changes
Jul 7, 2022
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
ghzlatarev
approved these changes
Jul 8, 2022
Dengjianping
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
stechu
pushed a commit
that referenced
this pull request
Jul 11, 2022
…652) * Switch AWS CI runners to intels from AMD Signed-off-by: Adam Reif <Garandor@manta.network> * Changelog Signed-off-by: Adam Reif <Garandor@manta.network> * remove machine size/price comments Signed-off-by: Adam Reif <Garandor@manta.network> Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Co-authored-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com> Signed-off-by: Shumo Chu <shumo.chu@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS has higher capacity on Intel machines over AMD, and our CI is frequently failing due to not enough machines being available at AWS, e.g. https://github.com/Manta-Network/Manta/runs/7220320067?check_suite_focus=true
This also scales down the runners to 16core, cheaper machines except for the
create-draft-release
workflow, which stays large in order to reduce waiting time for a release buildSigned-off-by: Adam Reif Garandor@manta.network
Description
closes: #599
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.