Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yi/retire mpl #657

Merged
merged 3 commits into from
Jul 8, 2022
Merged

Yi/retire mpl #657

merged 3 commits into from
Jul 8, 2022

Conversation

flame4
Copy link
Contributor

@flame4 flame4 commented Jul 8, 2022

retire manta-pc-launch with polkadot-launch

closes: #434


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Yi <flame0743@gmail.com>
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@flame4 flame4 added A-ci Area: Continuous Integration P-low Priority: Low labels Jul 8, 2022
@flame4 flame4 added this to the Long-Running/Tracking milestone Jul 8, 2022
@flame4
Copy link
Contributor Author

flame4 commented Jul 8, 2022

for testing this commit, i just tmp redirect the git workflow triggle into my own branch and test success.

link is: https://github.com/Manta-Network/Manta/actions/runs/2633924871 && 121cd89#diff-056e66723f492687c7bed005ddeaeb3e69843af7c06787f825e64fbc6128d536L6

Signed-off-by: Yi <flame0743@gmail.com>
@flame4
Copy link
Contributor Author

flame4 commented Jul 8, 2022

As mentioned in #434 , it's a enhancement of manta ci for historical reason.

we fork manta-pc-launch from polkadot-launch before since there's some unique function we want but the original repo does not support.

but for now, everything we need could be met up with polkadot-launch in ci so we can make manta-pc-launch retired, we don't need to maintain it anymore.

this issue just fixup every usage in ci workflow file.

ghzlatarev
ghzlatarev previously approved these changes Jul 8, 2022
Signed-off-by: Yi <flame0743@gmail.com>
Copy link
Contributor

@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@flame4 Thanks for your first contribution!

@Dengjianping Dengjianping merged commit 4ad12d3 into manta Jul 8, 2022
@Dengjianping Dengjianping deleted the Yi/retire-mpl branch July 8, 2022 12:19
stechu pushed a commit that referenced this pull request Jul 11, 2022
* retire manta-pc-launch with polkadot-launch

Signed-off-by: Yi <flame0743@gmail.com>

* delete tmp

Signed-off-by: Yi <flame0743@gmail.com>

* ADD CHANGELOG

Signed-off-by: Yi <flame0743@gmail.com>
Signed-off-by: Shumo Chu <shumo.chu@pm.me>
@Apokalip Apokalip added the L-deprecated Log: Issues and PRs related to deprication label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration L-deprecated Log: Issues and PRs related to deprication P-low Priority: Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire manta-pc-launch from our CI
4 participants