-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yi/retire mpl #657
Yi/retire mpl #657
Conversation
Signed-off-by: Yi <flame0743@gmail.com>
Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin. |
for testing this commit, i just tmp redirect the git workflow triggle into my own branch and test success. link is: https://github.com/Manta-Network/Manta/actions/runs/2633924871 && 121cd89#diff-056e66723f492687c7bed005ddeaeb3e69843af7c06787f825e64fbc6128d536L6 |
Signed-off-by: Yi <flame0743@gmail.com>
As mentioned in #434 , it's a enhancement of manta ci for historical reason. we fork manta-pc-launch from polkadot-launch before since there's some unique function we want but the original repo does not support. but for now, everything we need could be met up with polkadot-launch in ci so we can make manta-pc-launch retired, we don't need to maintain it anymore. this issue just fixup every usage in ci workflow file. |
Signed-off-by: Yi <flame0743@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@flame4 Thanks for your first contribution!
* retire manta-pc-launch with polkadot-launch Signed-off-by: Yi <flame0743@gmail.com> * delete tmp Signed-off-by: Yi <flame0743@gmail.com> * ADD CHANGELOG Signed-off-by: Yi <flame0743@gmail.com> Signed-off-by: Shumo Chu <shumo.chu@pm.me>
retire manta-pc-launch with polkadot-launch
closes: #434
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.