Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include calamari bootnodes in genesis #666

Merged
merged 1 commit into from
Jul 12, 2022
Merged

include calamari bootnodes in genesis #666

merged 1 commit into from
Jul 12, 2022

Conversation

grenade
Copy link
Contributor

@grenade grenade commented Jul 11, 2022

Description

includes calamari bootnodes in genesis chainspec

closes: #651


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@github-actions
Copy link

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

ghzlatarev
ghzlatarev previously approved these changes Jul 11, 2022
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to signoff for the DCO check

git rebase --signoff HEAD~1
git push -f origin Yi/retire-mpl

Signed-off-by: Rob Thijssen <rthijssen@gmail.com>
@stechu stechu merged commit 9c9ebce into manta Jul 12, 2022
@stechu stechu deleted the issue-651 branch July 12, 2022 02:51
@Garandor Garandor added the A-collator-program Area: Issues and PRs related to the Collator Program label Jul 12, 2022
@Garandor
Copy link
Contributor

@grenade what this merge means is that after the v3.2.1 client upgrade collator docs need updating

P.S. Please add the A-collator-program label to collator program issues, that way you can easily find relevant topics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-collator-program Area: Issues and PRs related to the Collator Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put Calamari Bootnodes in the genesis file
4 participants