-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual seal mode for dev #870
Conversation
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin. |
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
404dbc5
to
8cb383c
Compare
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: Charles Ferrell <charlie@manta.network>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
building from the current commit and running
I gave up after 5min |
Try submitting an extrinsic. It won't produce blocks unless a transaction is submitted We should document this in README |
the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM, looks great with the factored out builder.rs
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
* slot skip cause block2 stuck Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com> * slot skip cause block2 stuck Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com> * calamari works by only one collator Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com> * add dolphin localdev Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com> * add instant finalize Signed-off-by: Charles Ferrell <charlie@manta.network> * format Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com> * update dev name Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com> * build dev consensus Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com> Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com> Signed-off-by: Charles Ferrell <charlie@manta.network> Co-authored-by: Charles Ferrell <charlie@manta.network> Co-authored-by: Adam Reif <garandor@manta.network> Signed-off-by: SupremoUGH <francisco@manta.network>
Description
relates to OR closes: #828
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updated