Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MantaPay V1 for Dolphin V3 deployment #890

Merged
merged 99 commits into from
Nov 29, 2022
Merged

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Nov 8, 2022

Description

closes #888


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ferrell-code
ferrell-code previously approved these changes Nov 22, 2022
Dengjianping
Dengjianping previously approved these changes Nov 23, 2022
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Dengjianping
Dengjianping previously approved these changes Nov 23, 2022
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Copy link
Collaborator

@stechu stechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghzlatarev ghzlatarev merged commit abfa78e into manta Nov 29, 2022
@ghzlatarev ghzlatarev deleted the ghzlatarev/dolphin-v3-2 branch November 29, 2022 13:04
This was linked to issues Nov 30, 2022
zqhxuyuan pushed a commit that referenced this pull request Dec 7, 2022
* wip: start upgrading palllet

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: commit save point

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* wip: save point

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix mantapay mock

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* wip: checkpoint

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* wip: checkpoint

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* wip: checkpoint

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* chore: fix signature error and add address partition

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>

* wip: fix merge conflicts

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* v1 to v2

Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>

* v1 to v2 everywhere

Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>

* disable benchmarkiing for asset-manager

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use unsafe_no_prove_full in coin generation

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* More features for precompute_coins

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* proof-length update and comment

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update for v2 circuit

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Clean up

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix manta-pay benchmarks

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Re-enable asset-manager benchmarks

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Re-enable asset-manager benchmarks

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Clean up

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use latest comimt of manta-rs

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add dolphin-v3 chainspec

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix clippy

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix clippy for manta-pay tests

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Taplo fmt

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* More clippy

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* More consistent chain-spec string

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Simplify 0 check in id conversions

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Make utxo.is_transparent an enum isntead of bool, with Opaque variant as default

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix clippy

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* bug fixed:

Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>

* Update manta-rs to insert receiver utxo in to-public precomputed coins. Compiles but InvalidAuthorizationSignature

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use dolphin_properties for the new chain-spec, not calamari

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* rename is_transparent field to transparency since no longer a bool

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update with LightIncomingNote

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Revert precompute_coins.rs

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Remove println! macros

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update accumulator in to_private::prove_full and add a new test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add 2 more nodes for calamari-local integration tests

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Clean up tests

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Remove erroneously pulled in Cargo.lock changes

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix fmt in benchmark

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix precompute_coins.rs

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update to circuits v3

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix decode error

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* insert receiver1 before receiver 0 utxo

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix benchmark tests

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix linters

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Clean up types and add comments

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* BUmp rust version to 1.62

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Error handle a few expects

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Remove unwraps

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update manta-rs commit

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update Dolphin weights

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix linter

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use latest manta-rs commit|

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* 3 nodes instead of 5 in chain-spec

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Use json genesis file for DolphinV3

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Remove unused imports

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Update genesis json

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me>
Co-authored-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@ghzlatarev ghzlatarev linked an issue Dec 9, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
9 participants