Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull-ledger-diff ci test for calamari #919

Merged
merged 18 commits into from
Dec 19, 2022

Conversation

ghzlatarev
Copy link
Contributor

@ghzlatarev ghzlatarev commented Dec 9, 2022

Signed-off-by: Georgi Zlatarev georgi.zlatarev@manta.network

Description

closes: #918

  • Add pull-ledger-diff ci integration tests for Calamari runtime
  • Update the integration tests to use governance instead of sudo.

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration L-added Log: Issues and PRs related to addition labels Dec 9, 2022
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev and others added 2 commits December 14, 2022 16:17
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev added the A-dolphin Area: Issues and PRs related to the Dolphin Runtime label Dec 14, 2022
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev marked this pull request as ready for review December 14, 2022 18:25
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@Dengjianping
Copy link
Contributor

I will integrate a test into CI for dense_pull_ledger_diff in this PR tomorrow.

@Dengjianping
Copy link
Contributor

Dengjianping commented Dec 19, 2022

I will integrate a test into CI for dense_pull_ledger_diff in this PR tomorrow.

I would integrate dense_pull_ledger_diff test in another PR.
Let's merge it first.

And now we can use precompute-coins to test dense_pull_ledger_diff and pull_ledger_diff, that would be more reasonable. Currently we just insert UTXOs directly.

@ghzlatarev ghzlatarev self-assigned this Dec 19, 2022
@ghzlatarev ghzlatarev merged commit b5699bc into manta Dec 19, 2022
@ghzlatarev ghzlatarev deleted the ghzlatarev/pull-ledger-diff-calamari-ci branch December 19, 2022 17:19
ferrell-code pushed a commit that referenced this pull request Dec 27, 2022
* Add pull-ledger-diff ci test for calamari

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add bigger sleep

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add governance to rpc performance test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add governance to rpc performance test

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Temp

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Should work with governance. Needs cleanup

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Wait less for finalizaiton

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Clean up

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Clean up

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Add more sleep between governance executions

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* CLean up

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Reduce expected avg sync time

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Clean up

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Clean up

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

* Fix pass by reference

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>

Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-ci Area: Continuous Integration A-dolphin Area: Issues and PRs related to the Dolphin Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pull_ledger_diff test for Calamari runtime
3 participants