-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runtime upgrade test by using governance instead of SUDO #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
added
C-bug
Category: Issues documenting a bug
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-ci
Area: Continuous Integration
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
L-fixed
Log: Issues and PRs related to bug fixes
labels
Dec 14, 2022
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
changed the title
Ghzlatarev/update rtu
Fix runtime upgrade test by using governance instead of SUDO
Dec 15, 2022
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
ghzlatarev
requested review from
Garandor,
stechu,
Dengjianping and
ferrell-code
December 19, 2022 10:12
ferrell-code
previously approved these changes
Dec 19, 2022
Signed-off-by: Charles Ferrell <charlie@manta.network>
Garandor
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great PR!
ferrell-code
approved these changes
Dec 20, 2022
ferrell-code
added a commit
that referenced
this pull request
Dec 27, 2022
* Migrate runtime-upgrade test to mocha Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Bump spec-version for test Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Add trigger Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * use wget properlt to download last release binary Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix missing config-for-runtime-upgrade-test Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix directory Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * CLean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix test Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Get rid of testnet-ci chain-specs Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Use object for referendumIndex Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Use object for referendumIndex Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Use object for referendumIndex Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Clean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Clean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Check Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Check Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Check Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Check Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Check Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Check Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Check Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Fix runtime upgrade code Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Clean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Clean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Clean up Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Update all ci workflows Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Update all ci workflows Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Increase wait time Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Bump timeout Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Bump timeout Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Switch to -local Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Upload 9921 log Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Update runtime-upgrade resource Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Remove unused code Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Check block production in mocha test Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * Revert spec_version bumps that were for testing only Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> * fix duplicate line Signed-off-by: Charles Ferrell <charlie@manta.network> Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network> Signed-off-by: Charles Ferrell <charlie@manta.network> Co-authored-by: Charles Ferrell <charlie@manta.network> Co-authored-by: Adam Reif <garandor@manta.network> Signed-off-by: Charles Ferrell <charlie@manta.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-ci
Area: Continuous Integration
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
C-bug
Category: Issues documenting a bug
L-fixed
Log: Issues and PRs related to bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #323
Change trigger condition of the CI test, before it wasn't getting triggered on tags. Also the if condition for one of the sub-jobs was only being triggered for dolphin label.
Use governance instead of sudo account to submit runtime upgrade extrinsics. The old method could only upgrade a special ci chain-spec which included sudo in its genesis. That special chain-spec is now removed alltogether and we can trigger with
calamari-dev
chain-spec.Migrate the test JS/TS code from Dev-Tools repo to tests folder in this repo
Use mocha framework to assert the test conditions (that spec_version has increased)
Update the CI test to use the new mocha test.
Successful run: https://github.com/Manta-Network/Manta/actions/runs/3720978998
Before we can approve this PR for merge, please make sure that all the following items have been checked off:
L-
group to this PRA-
andC-
groups to this PRA-calamari
,A-dolphin
and/orA-manta
if your changes are meant for/impact either of these (CI depends on it)Files changed
in the Github PR explorer.Situational Notes:
BaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updated