Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set collator minimum bond to 4M KMA #937

Merged
merged 9 commits into from
Dec 24, 2022
Merged

Set collator minimum bond to 4M KMA #937

merged 9 commits into from
Dec 24, 2022

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Dec 20, 2022

Description

Calamari Functional change:

Testing changes:

  • add regression test for 400k-bonded collators
  • add parachain_staking to integration_test mock
  • refactored integration test for lazy_static ALICE-FERDIE keys

relates to OR closes: #933


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Adam Reif added 3 commits December 15, 2022 22:53
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor self-assigned this Dec 20, 2022
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime L-changed Log: Issues and PRs related to changes labels Dec 20, 2022
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, linters are failing though.
Also are there some easy tests that can be moved from teh QA sheet ?

Signed-off-by: Adam Reif <Garandor@manta.network>
ferrell-code
ferrell-code previously approved these changes Dec 20, 2022
…erroneously pass, address comments

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor
Copy link
Contributor Author

Also are there some easy tests that can be moved from teh QA sheet ?

Addressed all comments except the one above, i'll leave this to another PR

@Garandor Garandor merged commit deee53c into manta Dec 24, 2022
@Garandor Garandor deleted the garandor/4mill branch December 24, 2022 22:38
ferrell-code pushed a commit that referenced this pull request Dec 27, 2022
* change collation eligibility bond to 4mil

Signed-off-by: Adam Reif <Garandor@manta.network>

* wip: use lazy_static for testing accounts

Signed-off-by: Adam Reif <Garandor@manta.network>

* Integrationtest reorg and 400k regression test

Signed-off-by: Adam Reif <Garandor@manta.network>

* allow dead code

Signed-off-by: Adam Reif <Garandor@manta.network>

* Fix collator_with_400k_not_selected_for_block_production which would erroneously pass, address comments

Signed-off-by: Adam Reif <Garandor@manta.network>

* unimport std::clone, works with upgraded compiler

Signed-off-by: Adam Reif <Garandor@manta.network>

* fix collator join test to use parachain_staking instead of collator_selection

Signed-off-by: Adam Reif <Garandor@manta.network>

Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Charles Ferrell <charlie@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set collator limit to 4M KMA
4 participants