Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Manta Runtime #946

Merged
merged 9 commits into from
Dec 29, 2022
Merged

Update Manta Runtime #946

merged 9 commits into from
Dec 29, 2022

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Dec 26, 2022

Signed-off-by: Adam Reif Garandor@manta.network

Description

  • SessionKeys::new(unchecked_collator_keys("Dave")) => SessionKeys::from_seed_unchecked("Dave") and adapted chainspec files. This is better as it allows us to have Manta RT have only 2 SessionKeys from genesis, omitting the obsolete Aura key
  • Removed all nonessential pallets from manta RT except
    • sudo (which is a multisig)
    • staking (initial collators)
    • nimbus (block production)
    • Utility (handling operations in batches to make multisig sudo operation less painful)
    • Balances (preparation for token distribution and to make sure other accounts can fill up multisig controllers if need be)
    • Multisig (managing sudo)
    • DMP (saving the para from a SNAFU through relaychain governance)
    • preimage (to store future runtime upgrades)
  • node no longer uses service_aura for Manta RT
  • Set staking inflation to 0
  • filter all staking extrinsics ( sudo only )

relates to OR closes: #925


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • This PR is targeted against the current Milestone ( otherwise discuss if it can be added in time)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes labels Dec 26, 2022
@Garandor Garandor self-assigned this Dec 26, 2022
Adam Reif added 2 commits December 26, 2022 12:03
Signed-off-by: Adam Reif <Garandor@manta.network>
…T has 2 keys, Calamari/Dolphin have AuraId as extra key

Signed-off-by: Adam Reif <Garandor@manta.network>
@github-actions

This comment was marked as resolved.

Signed-off-by: Adam Reif <Garandor@manta.network>
node/src/chain_specs/manta.rs Show resolved Hide resolved
runtime/manta/Cargo.toml Show resolved Hide resolved
runtime/manta/src/lib.rs Show resolved Hide resolved
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@Garandor
Copy link
Contributor Author

xcm_config is missing from your commit @ghzlatarev

i'll try adding it

Adam Reif and others added 3 commits December 28, 2022 12:15
fmt
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Copy link
Contributor

@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please update the description to mention the reasoning for Utility, Balances, Multisig, DMP

@Garandor Garandor merged commit d55f236 into manta Dec 29, 2022
@Garandor Garandor deleted the garandor/manta branch December 29, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-cleanup Category: Issues documenting cleanup or PRs that clean code up L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Manta Runtime
5 participants