Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-only: Happy new year and make release checklist a top-to-bottom todolist instead of separate sections #962

Merged
merged 7 commits into from
Jan 5, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Jan 4, 2023

Only two files touched:

  • release issue template
  • crate_draft_releases.yml workflow

All other changes are just copyright updates

release issue:

  • Redone the sequence so we don't distinguish between client/runtime/all releases.
  • Now just follow top-to-bottom and do the step when appropriate

draft_releases:

  • Only triggers on git tags that start with a v

Signed-off-by: Adam Reif Garandor@manta.network

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-development Area: Development Resources and Upgrades L-skip Log: Will be skipped on changelog generation labels Jan 4, 2023
@Garandor Garandor self-assigned this Jan 4, 2023
.github/ISSUE_TEMPLATE/release.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release.md Show resolved Hide resolved
@Dengjianping
Copy link
Contributor

Can you update copyright year in this pr?

// Copyright 2020-2023 Manta Network.

.github/ISSUE_TEMPLATE/release.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/release.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in diff, but the Security Audit section always fails.

Not sure the best solution as I agree with the check, maybe just leave it as is.

Adam Reif added 2 commits January 4, 2023 10:15
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor
Copy link
Contributor Author

Garandor commented Jan 4, 2023

Not in diff, but the Security Audit section always fails.

Not sure the best solution as I agree with the check, maybe just leave it as is.

fixing this should be in scope for 4.0.1

…d notes

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor changed the title doc-only: Make release checklist a top-to-bottom todolist instead of separate sections dev-only: Make release checklist a top-to-bottom todolist instead of separate sections Jan 4, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
ferrell-code
ferrell-code previously approved these changes Jan 4, 2023
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor changed the title dev-only: Make release checklist a top-to-bottom todolist instead of separate sections dev-only: Happy new year and make release checklist a top-to-bottom todolist instead of separate sections Jan 5, 2023
@Garandor Garandor merged commit 1391a3f into manta Jan 5, 2023
@Garandor Garandor deleted the rewrite-release-checklist branch January 5, 2023 17:28
SupremoUGH pushed a commit that referenced this pull request Jan 10, 2023
…odolist instead of separate sections (#962)

Signed-off-by: SupremoUGH <francisco@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-development Area: Development Resources and Upgrades C-enhancement Category: An issue proposing an enhancement or a PR with one L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants