Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump storage trie version for manta RT #966

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Jan 5, 2023

Signed-off-by: Adam Reif Garandor@manta.network

Description

Simplest PR in the history of history. Relates to #385

Applies only to manta, not to calamari as that would need a migration.

The only question is whether we do any low-level shenanigans in pallet-manta-pay that would break from a change in trie layout to the point where we can't roll out mantapay on this chain later because of the difference. I found us only using storage API so I think we're good.

Tested the new RT for block production and looks fine.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-manta Area: Issues and PRs related to the Manta Runtime L-changed Log: Issues and PRs related to changes labels Jan 5, 2023
@Garandor Garandor self-assigned this Jan 5, 2023
@Garandor Garandor requested review from 0xHolly, Dengjianping, ferrell-code and ghzlatarev and removed request for 0xHolly January 5, 2023 22:00
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplest PR in the history of history

Famous last words, LGTM

@Garandor Garandor merged commit 0aeb92f into manta Jan 6, 2023
@Garandor Garandor deleted the garandor/manta-new-trie branch January 6, 2023 15:04
SupremoUGH pushed a commit that referenced this pull request Jan 10, 2023
Signed-off-by: SupremoUGH <francisco@manta.network>
SupremoUGH pushed a commit that referenced this pull request Jan 10, 2023
Signed-off-by: SupremoUGH <francisco@manta.network>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants