Suspend MantaPay when InternalLedgerError

[ghzlatarev]

Signed-off-by: Georgi Zlatarev georgi.zlatarev@manta.network

Description

The following errors mean that the ledger is uncrecovarble broken:

• ReceiverLedgerError::ChecksumError
• ReceiverLedgerError::MerkleTreeCapacityError
• TransferLedgerError::ChecksumError
• TransferLedgerError::VerifiyingContextDecodeError

When they occur we just trigger tx-pause pause_pallets for MantaPay, in order to shut down any further operations, until we figure out a way forward.

---

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

• Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
• Added one label out of the L- group to this PR
• Added one or more labels from the A- and C- groups to this PR
• Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
• Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

• If adding functionality, write unit tests!
• If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
• If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
• If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

[ferrell-code]

Nice, LGTM

[Dengjianping]

I forget or don't have the context. why do we suspend mantapay if this error happen?

[ghzlatarev]

I forget or don't have the context. why do we suspend mantapay if this error happen?

If these errors happen, the ledger is unrecoverable broken, so we should just shut it down.
Let me add a description, forgot about that.

will resolve in a new pr.

[ferrell-code]

A few more tests that make sure errors that shouldn't suspend mantapay indeed do not maybe useful too. Code LGTM though

[Garandor]

A few more tests that make sure errors that shouldn't suspend mantapay indeed do not maybe useful too. Code LGTM though

Each invocation of suspend_manta_pay_execution is behind a match, so i think this is reasonably certain not to blow up randomly even without tests.
Not sure how one would test absence of pausing for all other error conditions, the overflow recommends an external crate for this purpose. I would like an iter-all-possible-enum-value-combinations-and-match style test more for assurance that ONLY the listed combinations pause the ledger (adding single combination negative tests is fragile on adding new error types), but this is good enough already.
Merging into 401