This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Simplify some code #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzlatarev
reviewed
May 25, 2021
|
Thanks for this PR. This pallet is imported by Manta which does not have |
zhenfeizhang
added a commit
that referenced
this pull request
May 31, 2021
* Simplify some code (#53) * Simplify some code * Fix formatting * Apply the review suggestion * Use sp_std::vec! * compiles after refactoring * CI to include manta repo when pallet-manta-pay is updated (#55) * Test cross-repo CI * Disable other checks temporarily * Replace git link to pallet-manta-pay to local link * Fix yamllint errors * More yaml errors * Check for pallet-manta-pay 3 levels up * Revert temporarily disabled jobs * Must fail tests for the private_transfer extrinsic (#52) * Test for HASH-PARAM mismatch in private_transfer * Fix formatting * Adding test for transferring a spent coin * Test for existing coins * Fix formatting and broken tests * Adding test for invalid zkp param * Reuse logic better * Fix formatting * Test for zkp verification failure * Fix formatting * Reuse code * Invalid ledger state tests * Adding test for sender-2 spent coin * Added a couple of Reclaim tests. Restructured the file, added comments and reused code * Correct name * Add another helper * Another 2 helpers to reuse setup logic between tests * unimplemented! for the destroying asset test * Add [#ignore] to unimplemented! test * fix compiling errors * fix test Co-authored-by: Liu-Cheng Xu <xuliuchengxlc@gmail.com> Co-authored-by: Georgi Zlatarev <45011053+ghzlatarev@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.