Skip to content

Commit

Permalink
MTLManagedObjectAdapter: Fix a bug where errors are silently handled
Browse files Browse the repository at this point in the history
It was using `error` but this error is replaced later in the method and never
passed as an error.

```objective-c
if (error != NULL) {
    *error = tmpError;
}
```
  • Loading branch information
kylef committed Jan 24, 2014
1 parent eb2178a commit e21c9c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Mantle/MTLManagedObjectAdapter.m
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ - (id)managedObjectFromModel:(MTLModel<MTLManagedObjectSerializing> *)model inse
NSValueTransformer *attributeTransformer = [self entityAttributeTransformerForKey:propertyKey]; NSValueTransformer *attributeTransformer = [self entityAttributeTransformerForKey:propertyKey];
if (attributeTransformer != nil) transformedValue = [attributeTransformer transformedValue:transformedValue]; if (attributeTransformer != nil) transformedValue = [attributeTransformer transformedValue:transformedValue];


if (![managedObject validateValue:&transformedValue forKey:managedObjectKey error:error]) return NO; if (![managedObject validateValue:&transformedValue forKey:managedObjectKey error:&tmpError]) return NO;
[managedObject setValue:transformedValue forKey:managedObjectKey]; [managedObject setValue:transformedValue forKey:managedObjectKey];


return YES; return YES;
Expand Down

0 comments on commit e21c9c3

Please sign in to comment.