Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React v15.3.2 giving dependency errors #14

Closed
fvpDev opened this issue Oct 18, 2016 · 4 comments
Closed

React v15.3.2 giving dependency errors #14

fvpDev opened this issue Oct 18, 2016 · 4 comments

Comments

@fvpDev
Copy link

fvpDev commented Oct 18, 2016

Maybe have viewmodel be dependant on react 15.3.1 rather than ^15.3.1? Or if you can help me/us, how would we get rid of these errors? http://stackoverflow.com/questions/39692025/what-is-causing-the-npm-dependency-warning
Wait, might be answered here:
http://stackoverflow.com/questions/37312749/warning-npm-peer-requirements-not-installed-react15-0-2-installed-react0-14?rq=1

@fvpDev fvpDev closed this as completed Oct 18, 2016
@ManuelDeLeon
Copy link
Owner

The solution is to have a peer dependency on react, not a hard one. I don't
know which react is the lowest it works with, I think it's 15.2.0

On Oct 18, 2016 4:46 PM, "Fedor Parfenov" notifications@github.com wrote:

Closed #14 #14.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#14 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AED31g-9HC6Djap9A1207ibBlrQ96ddxks5q1UxLgaJpZM4KaX3D
.

@ManuelDeLeon
Copy link
Owner

I'll update it later tonight.

On Oct 18, 2016 4:55 PM, wrote:

The solution is to have a peer dependency on react, not a hard one. I
don't know which react is the lowest it works with, I think it's 15.2.0

On Oct 18, 2016 4:46 PM, "Fedor Parfenov" notifications@github.com
wrote:

Closed #14 #14.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#14 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AED31g-9HC6Djap9A1207ibBlrQ96ddxks5q1UxLgaJpZM4KaX3D
.

@fvpDev
Copy link
Author

fvpDev commented Oct 24, 2016

Well, I don't think it was a vm-react issue at all

@ManuelDeLeon
Copy link
Owner

Even then, it should be a peer dependency (It should work with the React version you have). Another reason is that it will help make it work with React-Native.

I just published 0.8.11 which has that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants