msConnectLayer(): fix potential double-free introduced by recent ossf…

…uzz fix (Coverity Scan 1526531)
MapServer · Oct 23, 2022 · 0454c14 · 0454c14
1 parent 46e346b
commit 0454c14
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/maplayer.c b/maplayer.c
@@ -2110,10 +2110,10 @@ int msConnectLayer(layerObj *layer,
   /* For internal types, library_str is ignored */
   if (connectiontype == MS_PLUGIN) {
     int rv;
-    msFree(layer->plugin_library);
-    msFree(layer->plugin_library_original);
 
+    msFree(layer->plugin_library_original);
     layer->plugin_library_original = msStrdup(library_str);
+
     rv = msBuildPluginLibraryPath(&layer->plugin_library,
                                   layer->plugin_library_original,
                                   layer->map);