Fix OGR autostyle font mapping problem (#3893)

MapServer · Nov 5, 2012 · 2a2a4db · 2a2a4db
1 parent e62fba0
commit 2a2a4db
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/mapogr.cpp b/mapogr.cpp
@@ -2553,21 +2553,28 @@ static int msOGRUpdateStyle(OGRStyleMgrH hStyleMgr, mapObj *map, layerObj *layer
       const char *pszFontName = OGR_ST_GetParamStr(hLabelStyle,
                                 OGRSTLabelFontName,
                                 &bIsNull);
-      const char *pszName = CPLSPrintf("%s%s%s", pszFontName, pszBold, pszItalic);
+      /* replace spaces with hyphens to allow mapping to a valid hashtable entry*/
+      char* pszFontNameEscaped = NULL;
+      if (pszFontName != NULL) {
+          pszFontNameEscaped = strdup(pszFontName);
+          msReplaceChar(pszFontNameEscaped, ' ', '-');
+      }
+
+      const char *pszName = CPLSPrintf("%s%s%s", pszFontNameEscaped, pszBold, pszItalic);
       bool bFont = true;
 
-      if (pszFontName != NULL && !bIsNull && pszFontName[0] != '\0') {
+      if (pszFontNameEscaped != NULL && !bIsNull && pszFontNameEscaped[0] != '\0') {
         if (msLookupHashTable(&(map->fontset.fonts), (char*)pszName) != NULL) {
           c->labels[0]->type = MS_TRUETYPE;
           c->labels[0]->font = msStrdup(pszName);
           if (layer->debug >= MS_DEBUGLEVEL_VVV)
             msDebug("** Using '%s' TTF font **\n", pszName);
-        } else if ( (strcmp(pszFontName,pszName) != 0) &&
-                    msLookupHashTable(&(map->fontset.fonts), (char*)pszFontName) != NULL) {
+        } else if ( (strcmp(pszFontNameEscaped,pszName) != 0) &&
+                    msLookupHashTable(&(map->fontset.fonts), (char*)pszFontNameEscaped) != NULL) {
           c->labels[0]->type = MS_TRUETYPE;
-          c->labels[0]->font = msStrdup(pszFontName);
+          c->labels[0]->font = msStrdup(pszFontNameEscaped);
           if (layer->debug >= MS_DEBUGLEVEL_VVV)
-            msDebug("** Using '%s' TTF font **\n", pszFontName);
+            msDebug("** Using '%s' TTF font **\n", pszFontNameEscaped);
         } else if (msLookupHashTable(&(map->fontset.fonts),"default") != NULL) {
           c->labels[0]->type = MS_TRUETYPE;
           c->labels[0]->font = msStrdup("default");
@@ -2577,6 +2584,8 @@ static int msOGRUpdateStyle(OGRStyleMgrH hStyleMgr, mapObj *map, layerObj *layer
           bFont = false;
       }
 
+      msFree(pszFontNameEscaped);
+
       if (!bFont) {
         c->labels[0]->type = MS_BITMAP;
         c->labels[0]->size = MS_MEDIUM;